I find your proposal quite interesting and sensible. Can you give an estimate of how much time this migration would consume? Perhaps you do want to do this migration?
I am curious what the other developers think about it.
Since there are already a lot of changes in the next release I would postpone this for a later release.
Regards,
mat
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Just to avoid loosing this information I copy/paste the mail from Jeff here (I find this very useful - thanks a lot to Jeff!):
Regarding the Maven 2 plugin coordination, some thoughts for you....
I maintained the Maven 1 dbUnit plugin for the last few years. Basically,
you will release dbUnit first and then release the plugin, even if these
tasks are just an hour apart :-), to update the plugin with the newly
released dbUnit version and any changes to the dependencies (otherwise Maven
won't find the newly released dbUnit dependency and will fail the build!).
To shorten the plugin release time after a dbUnit release, I suggest
publishing snapshots of dbUnit and the plugin regularly (the plugin snapshot
using the dbUnit snapshot) to encourage earlier testing and usage of both,
possibly as a weekly or even a nightly build. Publishing a HEAD snapshot
build nightly is a great practice!
I suggest different version numbers for each, as you may fix a bug in the
plugin but there was no dbUnit release change. If desired, you could have
them somewhat in sync, with the major or major.minor numbers staying in
sync, but point releases differing.
And if I can help with anything, please let me know...
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I'd welcome to move it to dbunit! But first of all I'd like to handle some critical bugs from the 2.4 release. Perhaps Roberto would like to do this now?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi Dan,
a log time has passed since we spoke about the migration of the maven plugin from codehaus to the dbunit project. I had a look at the sources now and I think that for these 4 classes it wouldn't event be necessary to create a separate module but it could be included in the default dbunit.jar as well as into the main pom.xml. I know that this is kind of a monolithic approach but we had the same discussion for the different supported RDBMSes and ended up in choosing this monolithic approach for now since there are only a handful of classes for each logical "module". So would it be okay for you to move the maven plugin sources/testclasses/docs into the dbunit project now? I have some time and will be able to do it the next couple of days.
Rgds,
matthias
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I committed a first shot (SVN rev.1089/1090) and would like you to check the current trunk. I added a pom.xml to the trunk so that we do not have anything to change on the parabuild server.
Some more questions:
1. Should we change the tracker and SCM URL of the maven plugin? +1 for me
2. May I change the license of the plugin to the LGPL? waiting for Dan's go (looks like nothing should be in the way)
3. I'd like to add the documentation for the maven-plugin to the main dbunit site. Is that sensible? For me this is easier to maintain but of course violates the modularisation
regards,
matthias
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I find your proposal quite interesting and sensible. Can you give an estimate of how much time this migration would consume? Perhaps you do want to do this migration?
I am curious what the other developers think about it.
Since there are already a lot of changes in the next release I would postpone this for a later release.
Regards,
mat
it is going to be some work for the migration.
- Current DBUnit needs to have a parent pom to host dbunit.jar and the plugin
as 2 sub projects. Take a look at codehaus'mojo mojo-parent's pom.xml
- Rename package for the plugin source.
I can help with the migration should take me around a couple nights
I would strongly suggest that DBUnit team should start thinking about the parent pom first in the next release, then plugin move becomes seemless.
I am currently fixed up dbunit-maven-plugin to be on the same level with 2.3.0
Let's wait for the opinions of the other developers (Roberto, Sebastien, Felipe, ...).
I'd like to vote +1 to include you in the dbunit team so that you could support doing the migration (of course only if you like).
I already pinged MOJO dev list asking for opinion for the move. We have done a few moves before such as jaxws, izpack pluings, etc.
For DBUnit move,
The below structure allows all projects to be released in one shot
trunk
pom.xml <--- top level parent pom
dbunit <--- the current structure but one level down
dbunit-maven-plugin
The next structure supports independent release of each module
trunk
dbunit-parent
dbunit
dbunit-maven-plugin
dbunit still have the main site
Just to avoid loosing this information I copy/paste the mail from Jeff here (I find this very useful - thanks a lot to Jeff!):
Regarding the Maven 2 plugin coordination, some thoughts for you....
I maintained the Maven 1 dbUnit plugin for the last few years. Basically,
you will release dbUnit first and then release the plugin, even if these
tasks are just an hour apart :-), to update the plugin with the newly
released dbUnit version and any changes to the dependencies (otherwise Maven
won't find the newly released dbUnit dependency and will fail the build!).
To shorten the plugin release time after a dbUnit release, I suggest
publishing snapshots of dbUnit and the plugin regularly (the plugin snapshot
using the dbUnit snapshot) to encourage earlier testing and usage of both,
possibly as a weekly or even a nightly build. Publishing a HEAD snapshot
build nightly is a great practice!
I suggest different version numbers for each, as you may fix a bug in the
plugin but there was no dbUnit release change. If desired, you could have
them somewhat in sync, with the major or major.minor numbers staying in
sync, but point releases differing.
And if I can help with anything, please let me know...
So do we still have interest on moving the m2 plugin over here, but make it a separate release cycle
or
we can leave it at codehaus, and invite some one well verse with dbunit to maintain it?
I'd welcome to move it to dbunit! But first of all I'd like to handle some critical bugs from the 2.4 release. Perhaps Roberto would like to do this now?
We should also check whether there are changes required on the parabuild configuration: http://parabuild.viewtier.com:8080/parabuild/index.htm?view=detailed&buildid=30 or whether the parabuild server is maintained by someone out of our reach.
Roberto, do you know anything about this?
Hi Dan,
a log time has passed since we spoke about the migration of the maven plugin from codehaus to the dbunit project. I had a look at the sources now and I think that for these 4 classes it wouldn't event be necessary to create a separate module but it could be included in the default dbunit.jar as well as into the main pom.xml. I know that this is kind of a monolithic approach but we had the same discussion for the different supported RDBMSes and ended up in choosing this monolithic approach for now since there are only a handful of classes for each logical "module". So would it be okay for you to move the maven plugin sources/testclasses/docs into the dbunit project now? I have some time and will be able to do it the next couple of days.
Rgds,
matthias
I committed a first shot (SVN rev.1089/1090) and would like you to check the current trunk. I added a pom.xml to the trunk so that we do not have anything to change on the parabuild server.
Some more questions:
1. Should we change the tracker and SCM URL of the maven plugin? +1 for me
2. May I change the license of the plugin to the LGPL? waiting for Dan's go (looks like nothing should be in the way)
3. I'd like to add the documentation for the maven-plugin to the main dbunit site. Is that sensible? For me this is easier to maintain but of course violates the modularisation
regards,
matthias
Accomplished by Dan and Matthias many years ago!
Ticket moved from /p/dbunit/feature-requests/101/
Can't be converted: