From: Jeff J. <jj...@ap...> - 2023-10-12 03:53:56
|
Your MR looks good (after you squash!). Congratulations, you now have committer privs. You can commit the YAML feature when you are ready. Let's start a new thread and discuss what next items you want to work on. For our work, please always commit only on branches and have another person (mainly me these days) review before merge to master. On Sun, Oct 8, 2023 at 9:01 PM Jeff Jensen <jj...@ap...> wrote: > Hi Björn, > > I commented on the MR. Not sure if you receive notifications from the > site or not, so also emailing you. Please process those and let me know! > > > On Mon, Sep 25, 2023 at 2:15 PM Jeff Jensen <jj...@ap...> wrote: > >> Hi Björn, >> >> I fully appreciate the fact that you all probably have very limited time >>> for dbunit work >> >> Yes, multiple life events have prevented my prior level of dbUnit work >> :-( . I assume that I will resume some dbUnit work again in some >> rather-future months, just not for the next few. >> >> I would gladly participate actively in dbunit maintenance >> >> Thank you for asking about this. Most of the help that I trusted and >> added in the recent years have faded from continuing to help (as often >> happens in OS), so it remains with me. It is a challenge to find trusted >> and interested developers! You successfully completed a prior feature >> improvement to dbUnit. Your interest is welcomed and I'm sure we'll move >> ahead with it. >> >> My first action would then of course be to incorporate the yaml dataset >>> support and release a new version. >> >> I have no personal interest in maintaining a YAML implementation or using >> it in dbUnit. I recognize others such as yourself would like to have that >> feature. Yes, granting you committer status implies that you would merge >> it! lol And maintain it, of course! >> >> Working with the Moderniser plugin violations would be the obvious next >>> step. >> >> Continuing to modernize dbUnit further is a great requirement to do; >> plenty of tasks to discuss and do for that after cleaning up Moderniser. >> Of higher concern, some recent merge requests/updates/bug reports exist >> that need processing, probably best to process them first. >> >> > Let me know what you think! >> Hopefully I've answered what you are looking for in the above, please let >> me know your further questions and suggestions. >> >> Next, I will review your YAML MR in depth, then finalize committer >> decision. Please allow me this next week to accomplish. >> >> >> On Thu, Sep 21, 2023 at 5:37 AM Björn Beskow <bb...@gm...> wrote: >> >>> Hi all, >>> >>> I’ve been using DBUnit for very many years, in recent years mostly via >>> dbRider (https://github.com/database-rider/database-rider) since using >>> Yaml datasets has been a requirement. >>> >>> In my current assignment, I work with the Karate test framework, and >>> need to be able to work with Yaml datasets. I would like to use DBUnit >>> directly in this situation (without the extra dependencies to dbRider). >>> Hence I would really need the yaml dataset support, for which I have >>> submitted a pull request to dbunit some years ago. >>> >>> I fully appreciate the fact that you all probably have very limited time >>> for dbunit work. I would gladly participate actively in dbunit maintenance, >>> if you would allow me. My first action would then of course be to >>> incorporate the yaml dataset support and release a new version. Working >>> with the Moderniser plugin violations would be the obvious next step. >>> >>> Let me know what you think! >>> >>> Best regards >>> /Björn >>> _______________________________________________ >>> dbunit-developer mailing list >>> dbu...@li... >>> https://lists.sourceforge.net/lists/listinfo/dbunit-developer >>> >> |