Re: [dbunit-developer] DbUnit 3.0: Coding Standards

[Roberto Lo G. <rlo...@gm...>]

What about inner classes to avoid duplicating names? I usually prefer
Table.Metadata and Database.Metadata rather than the TableMetadata and
DatabaseMetadata, and I'm using this approach on annotations too...
You'll see what it's in my mind soon on the 3.0 repo

If everyone interested in the 3.0 can register on the codehaus lists
we can move there the conversation

Il giorno 28/dic/2010, alle ore 07:17, John Hurst
<joh...@gm...> ha scritto:

> Hello,
>
> Since you asked about the interface naming convention, here are a few other coding standards I would like to adopt:
>
>   - We should switch to the Java standard brace style, which is end-of-line. Some of the committed code is already in this style, but the original code uses the opening-brace-on-its-own-line style. I think we should standardize the indentation size too. 4 chars?
>   - Classes, methods and fields should follow normal Java conventions. Underscores should not be used in field names like "_rowList". The interface ITableFilterSimple would be better named SimpleTableFilter or something like that. (Adjectives then noun.)
>   - We should name classes carefully and consistently. For example, we currently have IMetadataHandler and ITableMetaData, which is inconsistent.
>   - DbUnit exceptions should be changed to  unchecked exceptions. I don't think checked exceptions are helpful in DbUnit.
>   - Also I wonder whether generally DbUnit should wrap checked exceptions such as SQLException in unchecked exceptions. What do you think about this?
>
> There are my pedantic whines about coding standards.
>
> I would be happy to make some of these changes (in particular the non-breaking formatting changes), but we'll need the repo set up and access first.
>
> Regards
>
> John Hurst
>
> --
> Life is interfering with my game
> ------------------------------------------------------------------------------
> Learn how Oracle Real Application Clusters (RAC) One Node allows customers
> to consolidate database storage, standardize their database environment, and,
> should the need arise, upgrade to a full multi-node Oracle RAC database
> without downtime or disruption
> http://p.sf.net/sfu/oracle-sfdevnl
> _______________________________________________
> dbunit-developer mailing list
> dbu...@li...
> https://lists.sourceforge.net/lists/listinfo/dbunit-developer