Re: [dbunit-developer] AbstractDatabaseConnection.createTable needs schema name added to query?

[Zdeněk V. <zd...@vr...>]

Hi Roberto,

I have one virtual server for free.

Are you interested?

I would have time to maintain that server, but after Christmas :).

Regards,
Zdenek

On Fri, Dec 17, 2010 at 1:59 PM, Roberto Lo Giacco <rlo...@gm...> wrote:
> Humm.. this pushes us again toward an integration test platform.... I must
> do something to solve this problem, definitely.... I think I'll go for
> Amazon as it seem other options have failed and I'm now really tired to have
> such a fear any change can break other integrations.
> I would like starting with the following databases:
> Oracle 10
> PostgreSQL 8
> mySQL 5
> HiperSQL (HSQLDB) 2
> JDBC drivers yet have a great role on dbUnit test results... any suggestion
> about how to solve the problem? Use the "official" where available or the
> "mostly adopted" could be the solution?
> On Fri, Nov 26, 2010 at 03:03, Jeff Jensen <jj...@ap...> wrote:
>>
>> Hi guys,
>>
>> I encountered a problem with using schema names today.  The funny
>> thing is there is a comment by gomma on the line I needed to change to
>> fix - line 116 of AbstractDatabaseConnection.java says "// TODO Think
>> about QualifiedTableNames here - needed or not?".
>>
>> This is the current method:
>>    public ITable createTable(String tableName) throws
>> DataSetException, SQLException
>>    {
>>        logger.debug("createTable(tableName={}) - start", tableName);
>>
>>        if (tableName == null) {
>>            throw new NullPointerException("The parameter 'tableName'
>> must not be null");
>>        }
>>
>>        String sql = "select * from " + tableName; // TODO Think about
>> QualifiedTableNames here - needed or not?
>>        return this.createQueryTable(tableName, sql);
>>    }
>>
>> This is my suggested change:
>>    public ITable createTable(String tableName) throws
>> DataSetException, SQLException
>>    {
>>        logger.debug("createTable(tableName={}) - start", tableName);
>>
>>        if (tableName == null) {
>>            throw new NullPointerException("The parameter 'tableName'
>> must not be null");
>>        }
>>
>>        // qualify with schema if configured
>>        QualifiedTableName qualifiedTableName =
>>                new QualifiedTableName(tableName, this.getSchema());
>>        String qualifiedName = qualifiedTableName.getQualifiedName();
>>        String sql = "select * from " + qualifiedName;
>>        return this.createQueryTable(tableName, sql);
>>    }
>>
>> With adding the schema name to the table query, the problem I
>> encountered went away.
>>
>> Do any of you see any problem with this change?  If not, I will commit.
>>
>> Existing dbUnit tests pass and another of my customer apps with lots
>> of dbUnit tests but no schema name still works.
>>
>> It makes me wonder how tests with schemas currently work!  They must
>> not be using this method!
>>
>>
>> ------------------------------------------------------------------------------
>> Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
>> Tap into the largest installed PC base & get more eyes on your game by
>> optimizing for Intel(R) Graphics Technology. Get started today with the
>> Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
>> http://p.sf.net/sfu/intelisp-dev2dev
>> _______________________________________________
>> dbunit-developer mailing list
>> dbu...@li...
>> https://lists.sourceforge.net/lists/listinfo/dbunit-developer
>
>
> ------------------------------------------------------------------------------
> Lotusphere 2011
> Register now for Lotusphere 2011 and learn how
> to connect the dots, take your collaborative environment
> to the next level, and enter the era of Social Business.
> http://p.sf.net/sfu/lotusphere-d2d
> _______________________________________________
> dbunit-developer mailing list
> dbu...@li...
> https://lists.sourceforge.net/lists/listinfo/dbunit-developer
>
>