dbunit Merge Request #51: #244 Add support for Yaml dataset format (merged)

Adds support for yaml datasets

[Bjorn Beskow]

Rebased onto master as of 2021-01-02 to simplify merge.

[Bjorn Beskow]

Rebased onto master as of 2021-11-16 to simplify merge.

[Amra]

I am looking forward to using this feature.

Are there any obstacles to be solved before the merge?

[Bjorn Beskow]

No, it should be straight-forward. I updated snakeyaml dependency to latest version and rebased onto master again to simplify merge. Thanks!

[Bjorn Beskow]

[Bjorn Beskow]

I bumped the snakeyaml dependency to the latest version (2.2) again. The pull request is rebased onto the top of main, with no merge conflicts. The changes are small, they are fully tested and fully documented. Are there any further obstacles to accepting this merge request?

[Jeff Jensen]

The MR looks good, thank you. Tests are key for ongoing maintenance, good to see them. If you have more test cases to add, please do.

Look like you followed the steps on https://dbunit.sourceforge.net/dbunit/devguide.html quite well. I did not see changes.xml update for this feature though, please add that. Please alphabetize the new snakeYamlVersion property in the POM.

Also, please adjust your git commit to follow convention (change needed is topic doesn't have a period).

Did you run the build with each of the supported databases?

[Bjorn Beskow]

MR updated accordingly, thanks! Yes, the integration tests have been executed locally with all the containerized dbs (mssql, mssql2019, mysql, oracle11 and postgres).

[Jeff Jensen]

I do not see the changes in the MR, please verify it is updated.

[Bjorn Beskow]

Since you wanted me fix the original commit comment, I squashed all changes into the original commit and force-pushed it to my feature branch using the correct commit comment format. Hence you should find all changes (including the added changes.xml and the alfabetized dependency version properties in the pom.xml) in that single commit (which I can see still shows the timestamp from the original commit, which I agree is confusing). Have you tried the 'Refresh Commits' button? Sorry for the inconvenience!

[Jeff Jensen]

I squashed all changes into the original commit and force-pushed it to my feature branch

Yes, that sounds correct. However, this MR still had only the original contents. However, something you did around your latest message posting time updated the MR - the MR status message now shows it was just updated: "Bjorn Beskow wants to merge 1 commit from /u/bjornbeskow/dbunit/ to master, 23 minutes ago"

Have you tried the 'Refresh Commits' button?

That option does not exist for the reviewer.

Thanks for doing the tweaks; looks good.

Last one - in changes.xml <release> "description" attribute, please add a very brief summary (we add one per detailed entry); in this case "YAML dataset" should suffice.</release>

[Bjorn Beskow]

Release description added

[Jeff Jensen]

Looks good. Don't forget to squash!