dbunit Merge Request #50: Implement #232 (merged)

Adds support for filtering computed columns (and columns in general) out of datasets.

[Jeff Jensen]

Hi Rich,
What user docs/instructions should we add to describe how to use this new functionality?
(sincere apologies for the delay)

[Rich DiCroce]

The idea is to use a TableDecoratorDataSet to wrap an existing IDataSet. The TableDecoratorDataSet takes a function that is called for each table in the underlying dataset, and that function can wrap the table, replace the table, or just pass the table back as-is.

Here's a code snippet taken from a real application where I'm using this patch:

dataset = new TableDecoratorDataSet(
                dataset, table -> new ColumnFilterTable(table, new GeneratedColumnFilter()));

[Jeff Jensen]

Thank you. Do you have interest in adding site doc changes in the correct locations to your branch/MR for user docs?

[Rich DiCroce]

I assume that would involve adding TableDecoratorDataSet to the list of IDataSets on the Core Components page. Anything else I should do?

[Jeff Jensen]

Yes, definitely there; I didn't notice another location.
Thank you for adding docs too.

[Jeff Jensen]

Please rebase too, when ready.

[Rich DiCroce]

Finally got back to this. Rebased on latest master and added docs.

[Jeff Jensen]

An embarrassingly large amount of time has passed, sorry.

I fetched your branch into the dbUnit repo branch "F232-rich-computed-columns", rebased master, and pushed so Travis CI can build with the databases. Regretfully, the build fails so I cannot merge it:
https://travis-ci.com/github/dbunit/dbunit-mirror/builds/234058200

If you have interest and time to review that and fix, these steps outline the needs:
http://dbunit.sourceforge.net/devguide.html

and one step refers to the Integration Tests page which describes an easy way to run the same tests using Docker images of the databases.:
http://dbunit.sourceforge.net/integrationtests.html

[Rich DiCroce]

Well I've finally come back to this after an equally long amount of time. The project where I needed this was on ice for a while but now it's heating up again.

I've rewritten the patch on top of latest master and force pushed the branch. Although that doesn't seem to have updated this MR for whatever reason.

The build logs from that Travis run are long gone, of course, so I don't know why it failed. Try grabbing the updated branch and running it through Travis. If it fails again, I'll look at it to figure out why.

[Edward Mann]

Rich, i am looking over the existing merge requests wanting to get them caught up before i update to java 17+. I found your branch "computed-columns", i hope this is the correct one.

If not can you send me a link to it? I will pull it and work on tests that are failing. We will most likely need to create a new merge request from that branch.

Thanks

[Rich DiCroce]

Yes, that is the correct branch.

[Rich DiCroce]

Jeff/Edward: I've rebased this branch on top of latest master. Any chance one of you could review and merge it?

[Jeff Jensen]

Thank you Rich. We just merged the JUnit 5 updates to master. I did a quick rebase of your branch on that and stopped at compiler errors simply due to time. I can proceed with it in the near future but if you want it in the 3.0.0 release, please rebase yet one more should-be-last-time and should merge smoothly then.

[Rich DiCroce]

Done.

[Jeff Jensen]

Thank you for doing it again!
Regretfully its build fails on tests both my local and dbUnit CI on "java.sql.SQLException: Column not found: 24". https://gitlab.com/dbUnit/dbunit-extension/-/jobs/8175569590
Does the build pass for you?

[Rich DiCroce]

Fixed. That column has been in the JDBC spec since 4.1 but apparently some drivers still don't implement it. The tests are now all passing on my machine using the default HSQLDB profile.

[Jeff Jensen]

Great, thank you!
https://gitlab.com/dbUnit/dbunit-extension/-/pipelines/1511180040

[Jeff Jensen]

Your IDE formatting differs from dbUnit formatter so I tweaked a few files for that and also updated changes.xml. I squashed my changes into your commit. also updated commit message.

[Jeff Jensen]

Merged. Thank you so much for your patience and diligence with your updates.