dbunit Merge Request #45: Suggeste fix for #315 with regard to custom identity insert filter (merged)

Hello,
I have created a quick fix for the issue with the property for the IDENTITY_COLUMN_FILTER not being found. I fixes both the disabled failing IT and the issue I had in my local environment.
I had first tried a more sophisticated approach with dynamic loading of the properties, which worked in the ITs but not in my local environment.
I hope this is useful.
Regards,
Luc

[Jeff Jensen]

Thank you for the changes, couple of notes:

InsertIdentityOperationIT.java:

* Please don't use wildcard imports.
* testSetCustomIdentityColumnFilter: it was changed to opposite condition check; instead, do we need two tests?

[Luc Feys]

Thanks for your feedback:

• Wildcard import was added by my IDE. Had not noticed. Thought I had reverted it to an expanded list of imports. Have pushed a fix for this.
• About the opposite condition check: since the behaviour of the default column filter might be database version dependent, I want to make sure the filter used in the test actually makes a difference. If at some point the behavior of the default filter would change, this test would fail and could be changed again to prove the new filter is actually applied.

[Jeff Jensen]

OK, thanks for updating. Please squash them.

[Luc Feys]

Done

[Jeff Jensen]

Thanks. One more thing, sorry I didn't mention this in prior message - please add an entry to changes.xml for this (let me know if need help on that; dev is me, type is fix, due-to is you; add terse summary to end of description). And squash & rebase master again, please.

[Jeff Jensen]

Also, when you update the commit, please change the commit message, removing " + implement MR comments" and the # character. Something like: B315: Fix setting PROPERTY_IDENTITY_COLUMN_FILTER

[Luc Feys]

No problem. Updated changes.xml, squashed and changed commit message.

[Jeff Jensen]

Great, thank you. For changes.xml, please put your new entry as first in the list and add the add terse summary to end of description (something like Fix MSSQL identity column filter).

While you are at it, your branch is still missing commits from master so please rebase (eases my merge process).

[Luc Feys]

done.