Menu

dbunit Merge Request #42: F218: IDataSet.addTable[s]() functions implemented. (rejected)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Hans Deragon wants to merge 1 commit from /u/deragon/dbunit/ to master, 2018-08-16

The following member functions were implemented in IDataSet to easily
allow the addition of tables/table names to datasets.

addTable(ITable table)
addTables(Collection<itable> tables)
addTables(IDataSet dataSet)</itable>

Commit Date  
[750bed] (idataset-addtables-final) by Hans Deragon Hans Deragon

F218: IDataSet.addTables functions implemented.

The following member functions were implemented in IDataSet to easily
allow the addition of tables/table names to datasets.

addTable(ITable table)
addTables(Collection<ITable> tables)
addTables(IDataSet dataSet)

2018-04-18 00:47:38 Tree

Discussion

  • Jeff Jensen

    Jeff Jensen - 2018-04-16

    Hi Hans, build fails for me on Java 7 and 8, does it for you?

    [ERROR] Failures:
    [ERROR]   LowerCaseDataSetTest>AbstractDataSetTest.testAddTable:173->AbstractDataSetTest.assertEqualsTableName:103 name 6 expected:<[A]dded table> but was:<[a]dded table>
    [ERROR]   LowerCaseDataSetTest>AbstractDataSetTest.testAddTablesWithCollection:215->AbstractDataSetTest.assertEqualsTableName:103 name 6 expected:<[A]dded_table_nb_1> but was:<[a]dded_table_nb_1>
    [ERROR] Errors:
    [ERROR]   CaseInsensitiveDataSetTest>AbstractDataSetTest.testAddTable:172 » NoSuchTable ...
    [ERROR]   CaseInsensitiveDataSetTest>AbstractDataSetTest.testAddTablesWithCollection:214 » NoSuchTable
    [ERROR]   ForwardOnlyDataSetTest>AbstractDataSetTest.testAddTable:172 » UnsupportedOperation
    [ERROR]   StreamingDataSetTest>AbstractDataSetTest.testAddTablesWithCollection:214 » UnsupportedOperation
    [INFO]
    [ERROR] Tests run: 1152, Failures: 2, Errors: 4, Skipped: 1
    
     
  • Hans Deragon

    Hans Deragon - 2018-04-17

    Sorry about that. I forgot to run one set of tests. Code has been fixed. It should work now.

     
  • Jeff Jensen

    Jeff Jensen - 2018-08-16
    • Status: open --> rejected
     
  • Jeff Jensen

    Jeff Jensen - 2018-08-16

    Per our discussion, closing this because dbUnit approach is to use Composite DataSets, not add these methods.

     

Log in to post a comment.

MongoDB Logo MongoDB