Hi Puneet, thank you for the MR! Please make a few adjustments:
Please format your code lines as the other code. If using Eclipse, you may want to use the
Does the test accurately verify the PKs, I'm wondering if should check all of the array results from getPrimaryKeys() (in one assert vs over multiple?)?
Please squash all into one commit.
Please add the problem info from issue 405 into the commit message, in case we lose that URL someday, the source history will have the info.
Last edit: Jeff Jensen 2017-11-07
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi Puneet, thank you for the MR! Please make a few adjustments:
Last edit: Jeff Jensen 2017-11-07