Menu

dbunit Merge Request #38: https://sourceforge.net/p/dbunit/bugs/405/ (rejected)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Puneet Behl wants to merge 2 commits from /u/puneet739/dbunit/ to master, 2017-11-09

DBunit test for multi primary key

Commit Date  
[8d9685] by Puneet.behl Puneet.behl

Added Assertion

2017-11-07 14:26:31 Tree
[225e34] by Puneet.behl Puneet.behl

DBUnit Test Case for
https://sourceforge.net/p/dbunit/bugs/405/

2017-11-07 14:17:51 Tree

Discussion

  • Jeff Jensen

    Jeff Jensen - 2017-11-07

    Hi Puneet, thank you for the MR! Please make a few adjustments:

    • Please format your code lines as the other code. If using Eclipse, you may want to use the
    • Does the test accurately verify the PKs, I'm wondering if should check all of the array results from getPrimaryKeys() (in one assert vs over multiple?)?
    • Please squash all into one commit.
    • Please add the problem info from issue 405 into the commit message, in case we lose that URL someday, the source history will have the info.
     

    Last edit: Jeff Jensen 2017-11-07
  • Jeff Jensen

    Jeff Jensen - 2017-11-09
    • Status: open --> rejected
     

Log in to post a comment.

MongoDB Logo MongoDB