Menu

dbunit Merge Request #29: #199 FlatDtdDataSet has redundant code. (rejected)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Hans Deragon wants to merge 1 commit from /u/deragon/dbunit/ to master, 2017-10-22

Remove redundant code in FlatDtdDataSet.

FlatDtdDataSet did not make use of member fields and functions inherited from AbstractDataSet. Now the code has been simplified, opening the way for easier maintenance and extension.

Commit Date  
[f21dfb] by Hans Deragon Hans Deragon

Feature #199: FlatDtdDataSet has redundant code.

FlatDtdDataSet did not make use of member fields and functions inherited
from AbstractDataSet. Now the code has been simplified, opening the way
for easier maintenance and extension.

2017-07-07 01:40:53 Tree

Discussion

  • Jeff Jensen

    Jeff Jensen - 2017-07-08

    Looks good. In toString(), please tweak this:

    sb.append(", _tableMap=").append(this._orderedTableNameMap);
    

    to

    sb.append(", _orderedTableNameMap=").append(this._orderedTableNameMap);
    

    (and don't forget to squash it! :-)

     

    Last edit: Jeff Jensen 2017-07-08
  • Hans Deragon

    Hans Deragon - 2017-10-22
    • Status: open --> rejected
     
  • Hans Deragon

    Hans Deragon - 2017-10-22

    Actual code was merged with merge request #30. Closing this one.

     

Log in to post a comment.

MongoDB Logo MongoDB