Menu ▾ ▴

#309 MSSQL IdentityInsertOperation.execute erroneously always commits

v2.3.*
closed-fixed
Jeff Jensen
Bug (232)
2.5.4
5
2017-04-02
2010-12-02
Bjorn Beskow
No

IdentityInsertOperation.execute erroneously always commits the operation, even if the autoCommit property is false.
A fix is included, which adds the missing conditional logic: Call commit on successful operation if and only if autoCommit was originally set to true.

Discussion

  • Bjorn Beskow

    Bjorn Beskow - 2010-12-02

    IdentityInsertOperation patch

     
    InsertIdentityOperation.patch

  • Mario Zagar

    Mario Zagar - 2013-04-25

    +1 for this patch. I experienced the same problem, see details here.

     

    Last edit: Mario Zagar 2013-04-25

  • Guillermo

    Guillermo - 2013-06-14

    Any plans to include this simple patch? It's quite safe and would be really helpful.

     

  • Jeff Jensen

    Jeff Jensen - 2017-04-02
    • summary: IdentityInsertOperation.execute erroneously always commits --> MSSQL IdentityInsertOperation.execute erroneously always commits
    • status: open --> closed-fixed
    • assigned_to: matthias g --> Jeff Jensen
    • Fixed Release: --> 2.5.4
    • Found Release: --> v2.3.*
     

  • Jeff Jensen

    Jeff Jensen - 2017-04-02

    Committed for 2.5.4.