Menu

#252 primaryFilterKey is not always respected

closed-fixed
Bug (232)
5
2009-07-29
2009-07-17
David Zhang
No

http://www.dbunit.org/properties/primaryKeyFilter is only respected if it is set before the metadata is loaded for the first time in DatabaseTableMetadata.
I'm not sure if this is by design.

If it is by design, I think that it should be explicitly stated on the documentation.
If not, I think that in DatabaseTableMetaData.getPrimaryKeys(), in addition to checking if _primaryKeys is null, one should also check if the primaryKeysFilter property has been changed since its last invocation.

Discussion

  • David Zhang

    David Zhang - 2009-07-24
     
  • matthias g

    matthias g - 2009-07-29

    Your fix has been accepted and committed to the project repository.

    Thank you!

     
  • matthias g

    matthias g - 2009-07-29
    • assigned_to: slecallonnec --> gommma
    • status: open --> closed-fixed
     
  • matthias g

    matthias g - 2009-07-29

    Hi there,

    I committed your patch to svn rev. 1022/trunk. Thanks a lot!

    rgds,
    matthias

     

Log in to post a comment.