Menu

#1 Check return codes everywhere

closed-fixed
nobody
None
3
2007-03-26
2007-03-13
No

Some checks for return codes are missing.

Examples:
Would you like to add more error handling for return values from "malloc" like in the function "load_reglist_to_memory" and from "fclose" in the function "load_rules_to_memory"?
http://downloads.sourceforge.net/dbhub/dbhub-0.424.tar.gz

Discussion

  • Centurion

    Centurion - 2007-03-13
    • status: open --> open-accepted
     
  • Centurion

    Centurion - 2007-03-13

    Logged In: YES
    user_id=1289228
    Originator: NO

    OK, I will add missing error handlers to "loading to memory" functions from utils.c

    It will be Hhandlers like these from fileio.c (opening/reading files)
    and for malloc.

     
  • Centurion

    Centurion - 2007-03-13

    Logged In: YES
    user_id=1289228
    Originator: NO

    ok, I have finished with that, all function from utils.c were changed and error handlers for opening/reading/closing files and for malloc were added. Will be included in nex version of DB Hub.

     
  • Centurion

    Centurion - 2007-03-15

    Logged In: YES
    user_id=1289228
    Originator: NO

    DB Hub version 0.425 includes your request

     
  • Centurion

    Centurion - 2007-03-15
    • priority: 5 --> 3
    • status: open-accepted --> open-fixed
     
  • Markus Elfring

    Markus Elfring - 2007-03-15

    Logged In: YES
    user_id=572001
    Originator: YES

    Thanks for the update.

    There are still a few unchecked function calls.
    Examples:
    - close => read_config
    - fprintf => write_config_file
    - fseek => load_reglist_to_memory

    Would you like to detect every error situation as early as possible?

    Are you going to integrate your source files into a Subversion repository (at SourceForge)?

     
  • Centurion

    Centurion - 2007-03-15

    Logged In: YES
    user_id=1289228
    Originator: NO

    Do you check the function using some adavced debugger?
    Could you send me a full list of unchecked calls?

    I have made a CVS reposity for DB Hub http://dbhub.cvs.sourceforge.net/dbhub

     
  • Markus Elfring

    Markus Elfring - 2007-03-15

    Logged In: YES
    user_id=572001
    Originator: YES

    I do not use an advanced debugger for this issue so far. I just provide a little code review.
    Would you like to improve the code with the help of the tool "http://splint.org/"?

    Why do you prefer old-fashioned CVS over Subversion?

     
  • Centurion

    Centurion - 2007-03-15

    Logged In: YES
    user_id=1289228
    Originator: NO

    >Would you like to improve the code with the help of the tool
    >"http://splint.org/"?

    Testing it, thanx for hint.

    >Why do you prefer old-fashioned CVS over Subversion?

    SVN will be forced later, CVS is fine at this moment, to find out the main bugs.

     
  • Centurion

    Centurion - 2007-03-26
    • status: open-fixed --> closed-fixed
     

Log in to post a comment.

MongoDB Logo MongoDB