Code Review for Fix for Broken Error Messaging (Ad Hoc SQL)

Brought to you by: bolynyk, claraliu, maclee, peterkohlmann, pjohnso3

#78 Code Review for Fix for Broken Error Messaging (Ad Hoc SQL)

Status: open

Owner: nobody

Labels: None

Priority: 5

Updated: 2012-10-23

Created: 2012-10-23

Creator: shlm

Private: No

I have made a revision in the DBStatement_MySQL.php file to fix the error messaging for Ad Hoc SQL support. To fix this I added another branch to the if-else statement in the constructor. You can see this new branch at line 130. This branch checks the values of mysqli_error and mysqli_errno to see if they are set. If they are, that means the query failed. If not, the query was successful.

Discussion

Matthew Vandenbussche - 2012-10-24

Thanks this looks good, can you commit it to the /trunk/TEr4-dev

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Code Review for Fix for Broken Error Messaging (Ad Hoc SQL)

Group

Searches

Help

#78 Code Review for Fix for Broken Error Messaging (Ad Hoc SQL)

Discussion