Konnichiwa,
here is my small patch for dav-1.0.0. please apply.
list of changes:
- cleaner Makefile(s): to use the default Makefile rules, and remove some
unnecessary targets (Makefile, src/dac/Makefiles, src/dav/Makefile and
src/drv/Makefile)
- the correct option of depmod is -A, not -a (src/drv/Makefile)
- remove some unecessary header files (src/common/util.c)
- remove kernel header files and use userland header (ext2/ext2_fs.h)
instead (src/dac/dac.c). then dac.c can be compiled on debian and
other distros.
- use ext2_super_block instead of ext3_super_block, since ext2_super_block
struct includes fields of ext3 and can be used in this situation. besides,
there is no ext3_super_block in userland (src/dac/dac.c)
- fix some typos in src/drv/common_fbksinfo.c
- rename init_module() to dav_init(), cleanup_module() to dav_exit() and us=
e
module_init() and module_exit() to register dav_init and dav_exit. this is
conventional and recommended in kernel module programming
(src/drv/common_fbksinfo.c)
- clean up some blank lines and whitespaces in some source codes
$ diffstat dav.diff=20
Makefile | 30 +++++++++++++++---------------
doc/Makefile | 1 -
src/common/Makefile | 5 +----
src/common/util.c | 4 ----
src/dac/Makefile | 13 +++----------
src/dac/dac.c | 15 +++++----------
src/dav/Makefile | 6 +++---
src/drv/Makefile | 8 +++-----
src/drv/common_fbksinfo.c | 14 ++++++--------
9 files changed, 36 insertions(+), 60 deletions(-)
Signed-off-by: Nguyen Anh Quynh <aq...@gm...>
my suggestions:
- we should never use kernel header when programming in userland. in
the patch, i remove headers such as linux/ext2_fs.h and
linux/ext3_fs.h
- the name of kernel module fbksinfo is confused. why dont use the
name of the project: davtool or dav for this module? that is much less
confused when users look at the output of lsmod, right?
- port the dav gui to gtk2. gtk1.2 is pretty obsolete now, especially
on modern linux distros.
davtool is nice. please keep up the great job.
domo arigatou,
aq
|
