Typos aside, the logging class has a fairly fundamental issue.
The various functions and macros take a descriptive string, which is ok, but what if you want to pass parameters, variable values in the string? Well if it is one or two integers, or one or two strings, then you are fine. Mixing integers and strings or wanting more than two such variables appears to be a strict no no.
Why not just make one function that takes printf-like arguments? You could remove a whole load of functions and macros and replace them all with a single macro wrapped function. Much simpler. Therefore much better.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Typos aside, the logging class has a fairly fundamental issue.
The various functions and macros take a descriptive string, which is ok, but what if you want to pass parameters, variable values in the string? Well if it is one or two integers, or one or two strings, then you are fine. Mixing integers and strings or wanting more than two such variables appears to be a strict no no.
Why not just make one function that takes printf-like arguments? You could remove a whole load of functions and macros and replace them all with a single macro wrapped function. Much simpler. Therefore much better.