[Dancer-changes] dancer/src stacktrace.c,1.1.1.1,1.2
Brought to you by:
bagder
|
From: <ho...@us...> - 2003-09-14 21:37:37
|
Update of /cvsroot/dancer/dancer/src
In directory sc8-pr-cvs1:/tmp/cvs-serv517
Modified Files:
stacktrace.c
Log Message:
Highlight the code that is probably the cause of the crash loop in
bug #214999.
Index: stacktrace.c
===================================================================
RCS file: /cvsroot/dancer/dancer/src/stacktrace.c,v
retrieving revision 1.1.1.1
retrieving revision 1.2
diff -u -d -r1.1.1.1 -r1.2
--- stacktrace.c 13 Nov 2000 02:42:49 -0000 1.1.1.1
+++ stacktrace.c 14 Sep 2003 21:37:33 -0000 1.2
@@ -156,10 +156,13 @@
char buf[MAX_BUFFER_SIZE];
/*
- * Please note that vsprintf() is not ASync safe (ie. cannot safely
+ * FIXME: Please note that vsprintf() is not ASync safe (ie. cannot safely
* be used from a signal handler.) If this proves to be a problem
* then the cmd string can be built by more basic functions such as
* strcpy, strcat, and a homemade integer-to-ascii function.
+ * XXX: Wtf? Normally, I would DESTROY code of this sort, but as it's
+ * only being called when Dancer is compiled with DEBUG, we'll
+ * leave it in for now, and add a warning to 'make debug'.
*/
va_start(args, format);
vsprintf(cmd, format, args);
|