Menu

#12 Too short mission name length

open-rejected
nobody
None
5
2014-08-25
2009-12-12
Glenn Rice
No

The constant MISSION_NAME_LEN is too short and causes buffer overflow errors. This happens consistently if compiled with compiler optimization.

Discussion

  • Glenn Rice

    Glenn Rice - 2009-12-12
     
  • karx11erx

    karx11erx - 2009-12-12

    You cannot just mess with such definitions w/o making sure they are not used e.g. in level file formats.

     
  • karx11erx

    karx11erx - 2009-12-12

    You are e.g. breaking the save game format with your change. You had better posted a bug report explaining where exactly the crash occurs.

     
  • karx11erx

    karx11erx - 2009-12-12
    • status: open --> open-rejected
     
  • Glenn Rice

    Glenn Rice - 2009-12-12

    Alright, I will find the exact place in your code where the overflow occurs and patch it in another way. I don't think this breaks the save game format as you claim though.