test:
1) untick any default rule
2) click "save changes"
Note the misleading "confirmation" displayed, stating "a new rule has been added"
=============
test:
1) add a new rule "yahoo.com"
2) type "yahoo.com" into addressbar + press enter
Yep, the request is squelched... and "1" along with "NOT Clean" is dipslayed.
This is not sufficient feedback.
Please consider displaying a text like "destination blocked, per your Cyberdragon rules" to the content pane of the active tab. Ah, on second thought, text invites multilingual/translation work. Instead, how about displaying a "blocked" image (read from disk? stored within the app as bitmap data?)
==============
The app is "keeping track" (amended config.ini) of which rules are inactive (unticked) by writing to config.ini
ouch! This is non-ideal. What if 30K rules AND 22K are unticked?!?
Also, some users will prefer to manually edit/maintain rules file from a text editor... and user currently has no way, short of jumping between viewing config.ini and filters.txt, to determine which rules are active (vs unticked, in app).
Ouch! this scenario is not easily maintainable!
I believe that the "status" of each rule should be reflected directly in its filters.txt entry
e.g., when loading the rules file and when saving changes, parser recognizes that "a line beginning with a # indicates a currently inactive rule".
==============
test:
1) launch app and re-enable the "yahoo.com" rule
2) type "blahblah-yahoo.com" into addressbar and press enter
3) press enter repeatedly and note that (nonsensically) the "LED-looking numeral one" is incremented
Note how time-consuming it is to even FIND the yahoo entry displayed in the TrackerBlocker list. Doesn't QT support a "jump to" or "find within" for that type of widget?
Last edit: sandax 2014-08-01
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Yea, saving status should probably directly go to filter list and not config.ini.
"test:
1) launch app and re-enable the "yahoo.com" rule
2) type "blahblah-yahoo.com" into addressbar and press enter
3) press enter repeatedly and note that (nonsensically) the "LED-looking numeral one" is incremented
"
That's actually a pretty bad bug!
Qt does not provide any premade "find within" but it does offer
crude form of "jump to" functionality by default.
To use that jump mechanism, focus tracker blocker rule view (by selecting any rule) and then press the first key of rule that you want.
But even that will take you only to the first rule that beging with that character, not the rule you necessarily want.
I could maybe add some find or filter field for rules.
Last edit: Stefan Fröberg 2014-08-01
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
test:
1) untick any default rule
2) click "save changes"
Note the misleading "confirmation" displayed, stating "a new rule has been added"
=============
test:
1) add a new rule "yahoo.com"
2) type "yahoo.com" into addressbar + press enter
Yep, the request is squelched... and "1" along with "NOT Clean" is dipslayed.
This is not sufficient feedback.
Please consider displaying a text like "destination blocked, per your Cyberdragon rules" to the content pane of the active tab. Ah, on second thought, text invites multilingual/translation work. Instead, how about displaying a "blocked" image (read from disk? stored within the app as bitmap data?)
==============
The app is "keeping track" (amended config.ini) of which rules are inactive (unticked) by writing to config.ini
ouch! This is non-ideal. What if 30K rules AND 22K are unticked?!?
Also, some users will prefer to manually edit/maintain rules file from a text editor... and user currently has no way, short of jumping between viewing config.ini and filters.txt, to determine which rules are active (vs unticked, in app).
Ouch! this scenario is not easily maintainable!
I believe that the "status" of each rule should be reflected directly in its filters.txt entry
e.g., when loading the rules file and when saving changes, parser recognizes that "a line beginning with a # indicates a currently inactive rule".
==============
test:
1) launch app and re-enable the "yahoo.com" rule
2) type "blahblah-yahoo.com" into addressbar and press enter
3) press enter repeatedly and note that (nonsensically) the "LED-looking numeral one" is incremented
Note how time-consuming it is to even FIND the yahoo entry displayed in the TrackerBlocker list. Doesn't QT support a "jump to" or "find within" for that type of widget?
Last edit: sandax 2014-08-01
Yea, saving status should probably directly go to filter list and not config.ini.
"test:
1) launch app and re-enable the "yahoo.com" rule
2) type "blahblah-yahoo.com" into addressbar and press enter
3) press enter repeatedly and note that (nonsensically) the "LED-looking numeral one" is incremented
"
That's actually a pretty bad bug!
Qt does not provide any premade "find within" but it does offer
crude form of "jump to" functionality by default.
To use that jump mechanism, focus tracker blocker rule view (by selecting any rule) and then press the first key of rule that you want.
But even that will take you only to the first rule that beging with that character, not the rule you necessarily want.
I could maybe add some find or filter field for rules.
Last edit: Stefan Fröberg 2014-08-01