With the std=c++20 option, gcc would not compile.
This is due to a few constructors in some templates that are written as Foo<t> instead of just Foo. This should not affect
I have attached a tiny diff file that shows the necessary patch to apply to fix this.</t>
Oups, I meant this should not afffect other compilers as this is the standard way to declare constructors.
Thanks. I'll run it pass my tests
patch does not like the diff.
Can you create the diff with svn diff please?
Or if you doing this outside of svn then use diff -u?
The diff should look like this format:
Last edit: Barry Alan Scott 2022-08-07
Hi Barry,
Here it is. I actually do not use svn.
I have been unable to provide a multi-file diff that is understandable by patch.
There are 2 files to patch, one for Python2 the other for Python3. I have not tested the patch for Python2 but it is mostly the same as for Python3 (and it is very simple).
I have attached the diffs for the individual files and a global file for both by using diff -ru. If you have a look on these files, you’ll see it is very simple.
Sorry for the inconvenience.
Regards,
-
- César Douady
- Doliam
- Senior Hardware & Software architect
- +33 6 30 71 90 61
-
Related
Patches: #30
I'm updating build to allow testing against each standard.
Your patch is good for c++11 to c++20 with GCC.
I see some issues with c++98 and c++03 but I happy to not support that far back in time.
I'll go on to test with MSVC and xcode/llvm next.
I think I will not patch python 2 files are these are, I hope, at this point for legacy systems that will not need the patch and may be using very old compilers.