Re: [cx-oracle-users] Re: cx_Oracle Python utility

[Geoff G. <ge...@ge...>]

Quoting Anthony Tuininga (an...@co...):
> Its not a "feature" but rather a result of the fact that I only actually
> use Python 2.2 and Python 2.3 now. I have no problem with a patch of
> that nature. Have you run the test suite after building with that patch?
> And does it pass completely (other than the Python 2.2 specific stuff)?

Ah, would that I could be in your situation.

I have not run the test suite. When I just tried (python test.py) to
run it under the unpatched version, I got an error:

  Traceback (most recent call last):
    File "test.py", line 42, in ?
      loader = unittest.TestLoader()
  AttributeError: 'unittest' module has no attribute 'TestLoader'

But maybe I'm running the tests improperly; I haven't spent a lot of
time trying to figure this out. Regardless, it's only a one line fix
in a fairly isolated location. If it appears that this patch causes a
problem, I'd be surprised. Well, any problem other than aesthetic. As
I said, it lacks a bit of the elegance you might desire.

> I don't have any problem applying such a patch. I am a little confused,
> though. You say that cx_Oracle 3.1 builds acceptably under Python 2.1.3.
> I assume that means that you got a warning about PyString_FromFormat
> during compilation which turned into a dynamic link error at runtime?
> You can either post this on SourceForge or simply resend me the patch in
> an attachment -- either will do.

I didn't notice the first few times, because the Oracle (8.1.5)
headers generate several warnings of their own, but there it is:

  cx_Oracle.c: In function `MakeDSN':
  cx_Oracle.c:149: warning: implicit declaration of function `PyString_FromFormat'
  cx_Oracle.c:151: warning: return makes pointer from integer without a cast

I've sent the patch as an attachment this time. If you have any
questions, please let me know.

Thanks,
--G.

-- 
Geoff Gerrietts                                 <geoff at gerrietts net> 
"A man can't be too careful in the choice of his enemies." --Oscar Wilde