#217 Dialogs need minimize buttons

WinCvs
closed
nobody
5
2002-03-13
2002-02-17
No

The dialogs displayed for things like checking out a
project should have minimize buttons.

Discussion

  • ccpearson

    ccpearson - 2002-02-18

    Logged In: YES
    user_id=318982

    I fixed this locally by calling SetWindowLong(hwnd,
    GWL_STYLE, WS_MINIMIZEBOX). Couldn't use
    wxWindow::SetWindowStyle() because it only updates the
    wxWindow object, not the actual window. Maybe a wxWindows
    guru knows a better way?

    Anyway, I haven't checked this in because of some related
    UI issues:

    - Even though the maximize button is disabled, once dialog
    is minimized you can maximize it from the Taskbar. Maxed
    dialog is ugly, but probably tolerable. However, there is
    then no way to "restore" maxed dialog to original size,
    because restore button is disabled.

    - Since the dialogs aren't modal wrt the Explorer window,
    you can open multiple instances of same dialog (e.g.
    checkout) from different folders. It's then not readily
    apparent which dialog will operate on which folder -- if
    you use wrong dialog you could hose your workspace. The
    confusion is worse when the dialogs are minimized. My
    solution was simply to put the folder name in the dialog
    caption (e.g. "TortoiseCVS - Checkout Module -
    c:\foo\bar"). I'd like to get some feedback on that before
    checking in.

    - I'm not sure exactly which dialogs need to be
    minimized. "All of them" would be the easy answer, but in
    fact, some of these dialogs (e.g. preferences) should
    probably be modal to prevent multiple instances, in which
    case you wouldn't minimize those.

    -- Chris <ChrisCPearson@acm.org>

     
  • ccpearson

    ccpearson - 2002-02-18

    Logged In: YES
    user_id=318982

    I fixed this locally by calling SetWindowLong(hwnd,
    GWL_STYLE, WS_MINIMIZEBOX). Couldn't use
    wxWindow::SetWindowStyle() because it only updates the
    wxWindow object, not the actual window. Maybe a wxWindows
    guru knows a better way?

    Anyway, I haven't checked this in because of some related
    UI issues:

    - Even though the maximize button is disabled, once dialog
    is minimized you can maximize it from the Taskbar. Maxed
    dialog is ugly, but probably tolerable. However, there is
    then no way to "restore" maxed dialog to original size,
    because restore button is disabled.

    - Since the dialogs aren't modal wrt the Explorer window,
    you can open multiple instances of same dialog (e.g.
    checkout) from different folders. It's then not readily
    apparent which dialog will operate on which folder -- if
    you use wrong dialog you could hose your workspace. The
    confusion is worse when the dialogs are minimized. My
    solution was simply to put the folder name in the dialog
    caption (e.g. "TortoiseCVS - Checkout Module -
    c:\foo\bar"). I'd like to get some feedback on that before
    checking in.

    - I'm not sure exactly which dialogs need to be
    minimized. "All of them" would be the easy answer, but in
    fact, some of these dialogs (e.g. preferences) should
    probably be modal to prevent multiple instances, in which
    case you wouldn't minimize those.

    -- Chris <ChrisCPearson@acm.org>

     
  • - 2002-03-13

    Logged In: YES
    user_id=303300

    Moved to TortoiseCVS project #529302

     
  • - 2002-03-13
    • status: open --> closed
     

Log in to post a comment.