cvsacl-users

[cvsacl-users] Segmentation fault when using UseSeperateACLFileForEachDir=yes

[Alex H. <ah...@ke...>]

I have created a new repository and have changed the aclconfig parameter
to UseSeperateACLFileForEachDir=yes.

[cvsadm@cvs cvsadm]$ cvs racl cvsadm:p -r ALL -d ALL
cvs racl: cannot open file: /home/cvsadm/temp/ALL/access
X ALL
cvs racl: cannot open file: /home/cvsadm/temp//home/cvsadm/temp/./access
cvs racl: cannot open file: /home/cvsadm/temp//home/cvsadm/temp/./access
Segmentation fault

I believe the segmentation fault occurs because and fseek is attempted on
a NULL file descriptor on aproximately line 1755 in acl.c.  Looks like the
file name is not valid.

Alex

[cvsacl-users] Segmentation fault when using UseSeperateACLFileForEachDir=yes

[Stig H. <sti...@cy...>]

Hi,

For the sake of making cvs-1.11.17-cvsacl-1.2.1-patched work I created a 
small patch for this little problem.
This thing is that 'accessfilecount' was not initialize if 'file' was 
not null.

By move the accessfilecount up above the if construct (and thus out of 
it), it is insured, that it is initialized to whatever 'intcount' is set to.

I fooled around with it and made a LOT of directories and files - no 
problems and access rights are handle properly.

Patch is attached!

(If the attachment doesn't come through, then let me know where to put it)

Cheers
Stig :))

Re: [cvsacl-users] Segmentation fault when using UseSeperateACLFileForEachDir=yes

[<sb...@us...>]

Hi Stig,

Thank you,

Regards,
sb...@us...


----- Original Message ----- 
From: "Stig Hornuff" <sti...@cy...>
To: <cvs...@li...>
Sent: Tuesday, July 13, 2004 2:57 PM
Subject: [cvsacl-users] Segmentation fault when using
UseSeperateACLFileForEachDir=yes


> Hi,
>
> For the sake of making cvs-1.11.17-cvsacl-1.2.1-patched work I created a
> small patch for this little problem.
> This thing is that 'accessfilecount' was not initialize if 'file' was
> not null.
>
> By move the accessfilecount up above the if construct (and thus out of
> it), it is insured, that it is initialized to whatever 'intcount' is set
to.
>
> I fooled around with it and made a LOT of directories and files - no
> problems and access rights are handle properly.
>
> Patch is attached!
>
> (If the attachment doesn't come through, then let me know where to put it)
>
> Cheers
> Stig :))
>
>

[cvsacl-users] acl.c & cvsacl-patch-1.2.0

[<sb...@us...>]

Hi,

Patch works now, when UseSeparateACLFileForEachDir=yes
UseSeparateACLFileForEachDir is correct spelling, so i changed it.
Thank you for reporting errors.
Regards,
Baris
sb...@us...

Re: [cvsacl-users] acl.c & cvsacl-patch-1.2.0

[Alex H. <ah...@ke...>]

Thanks for the update.  Everything is compiling okay and cvsacl appears to
be working now with the UseSeparateACLFileForEachDir=yes option.

Alex

On Thu, 24 Jun 2004 sb...@us... wrote:

> Hi,
> 
> Patch works now, when UseSeparateACLFileForEachDir=yes
> UseSeparateACLFileForEachDir is correct spelling, so i changed it.
> Thank you for reporting errors.
> Regards,
> Baris
> sb...@us...
>