Menu
▾
▴
[Cvs-syncmail] [ cvs-syncmail-Bugs-583345 ] ValueError: unpack list of wrong size
|
From: SourceForge.net <no...@so...> - 2003-03-18 15:28:42
|
Bugs item #583345, was opened at 2002-07-18 09:26 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=450019&aid=583345&group_id=47611 Category: None Group: None >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: Mike Noyes (mhnoyes) >Assigned to: Fred L. Drake, Jr. (fdrake) Summary: ValueError: unpack list of wrong size Initial Comment: Imports that contain empty directories cause a ValueError. Traceback (innermost last): File "/cvsroot/leaf/CVSROOT/syncmail", line 322, in ? main() File "/cvsroot/leaf/CVSROOT/syncmail", line 315, in main blast_mail(subject, people, specs[1:], contextlines, fromhost) File "/cvsroot/leaf/CVSROOT/syncmail", line 240, in blast_mail print calculate_diff(file, contextlines) File "/cvsroot/leaf/CVSROOT/syncmail", line 139, in calculate_diff file, oldrev, newrev = string.split(filespec, ',') ValueError: unpack list of wrong size ---------------------------------------------------------------------- >Comment By: Fred L. Drake, Jr. (fdrake) Date: 2003-03-18 10:40 Message: Logged In: YES user_id=3066 Ok, I think this is fixed in CVS now. I checked in a modified version of the patch that should with both the %s replacement in the command line and with files that contain commas in the filename. Try using syncmail 1.29 from the cvs-syncmail CVS. ---------------------------------------------------------------------- Comment By: Michael Hohmuth (rotofoil) Date: 2003-03-18 10:00 Message: Logged In: YES user_id=535753 Here's a simple patch that avoids the error with a loginfo specification of "%s" (as opposed to "${sVv}"). (For file names containing commas (","), the error is avoided, too, but no diff is generated.) Michael Index: syncmail =================================================================== RCS file: /cvsroot/opencxx/CVSROOT/syncmail,v retrieving revision 1.1 retrieving revision 1.2 diff -u -p -r1.1 -r1.2 --- syncmail 18 Mar 2003 14:31:01 -0000 1.1 +++ syncmail 18 Mar 2003 14:32:30 -0000 1.2 @@ -136,7 +136,12 @@ def usage(code, msg=''): def calculate_diff(filespec, contextlines): - file, oldrev, newrev = string.split(filespec, ',') + fspecrev = string.split(filespec, ',') + if len(fspecrev) <> 3: + return '' + + file, oldrev, newrev = fspecrev + # Make sure we can find a CVS version number if not REVCRE.match(oldrev): return NOVERSION % filespec ---------------------------------------------------------------------- Comment By: Patrik Fimml (fipa) Date: 2002-12-31 07:19 Message: Logged In: YES user_id=655162 I've got the same problem always when I want to create a module. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2002-12-03 08:53 Message: Logged In: NO Imports that contain a comma "," in the file name also cause the ValueError. It would be nice to see this fixed! ---------------------------------------------------------------------- Comment By: Johan Andersson (mrphonig) Date: 2002-08-18 09:09 Message: Logged In: YES user_id=579869 I got this error when I imported about 500 files at the same time. ---- Traceback (most recent call last): File "/cvsroot/bin/syncmail", line 322, in ? main() File "/cvsroot/bin/syncmail", line 315, in main blast_mail(subject, people, specs[1:], contextlines, fromhost) File "/cvsroot/bin/syncmail", line 240, in blast_mail print calculate_diff(file, contextlines) File "/cvsroot/bin/syncmail", line 139, in calculate_diff file, oldrev, newrev = string.split(filespec, ',') ValueError: unpack list of wrong size ---------------------------------------------------------------------- Comment By: Mike Noyes (mhnoyes) Date: 2002-08-14 09:23 Message: Logged In: YES user_id=39521 Ernst, I've always used "%{sVv}". It doesn't correct the problem I reported above. ref. http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/leaf/CVSROOT/ ---------------------------------------------------------------------- Comment By: Ernst de Haan (znerd) Date: 2002-08-14 07:35 Message: Logged In: YES user_id=11053 I solved the problem by using %{sVv} instead of %s only. For example: test $CVSROOT/CVSROOT/syncmail %{sVv} cv...@cv... ---------------------------------------------------------------------- Comment By: Ernst de Haan (znerd) Date: 2002-08-14 07:32 Message: Logged In: YES user_id=11053 I have the same problem with revision 1.20. ---------------------------------------------------------------------- Comment By: Chris Boot (bootc) Date: 2002-08-12 14:47 Message: Logged In: YES user_id=151802 This also seems to be related to a problem when checking files in directories that have spaces in their names. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=450019&aid=583345&group_id=47611 |
