cvs-syncmail-talk

[Cvs-syncmail] CVSROOT syncmail,1.10,1.11

[<bw...@us...>]

Update of /cvsroot/cvs-syncmail/CVSROOT
In directory usw-pr-cvs1:/tmp/cvs-serv11428

Modified Files:
	syncmail 
Log Message:
Sebastian Ude's patch to include the realname of the developer


Index: syncmail
===================================================================
RCS file: /cvsroot/cvs-syncmail/CVSROOT/syncmail,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -d -r1.10 -r1.11
--- syncmail	23 May 2002 17:52:23 -0000	1.10
+++ syncmail	23 May 2002 19:45:26 -0000	1.11
@@ -222,20 +222,21 @@
         conn = smtplib.SMTP()
         conn.connect(MAILHOST, MAILPORT)
         user = pwd.getpwuid(os.getuid())[0]
+        name = pwd.getpwuid(os.getuid())[4]
         domain = fromhost or getfqdn()
-        author = '%s@%s' % (user, domain)
+        address = '%s@%s' % (user, domain)
         s = StringIO()
         sys.stdout = s
         try:
             print '''\
-From: %(author)s
+From: %(name)s <%(address)s>
 To: %(people)s
 Subject: %(subject)s
 X-Mailer: Python syncmail %(version)s <http://sf.net/projects/cvs-syncmail>
-''' % {'author' : author,
-       'people' : string.join(people, COMMASPACE),
-       'subject': subject,
-       'version': __version__,
+''' % {'address' : address,
+       'people'  : string.join(people, COMMASPACE),
+       'subject' : subject,
+       'version' : __version__,
        }
             s.write(sys.stdin.read())
             # append the diffs if available

Re: [Cvs-syncmail] CVSROOT syncmail,1.10,1.11

[Sebastian U. <ud...@ha...>]

On Thu, 23 May 2002, bw...@us... wrote:
> Date: Thu, 23 May 2002 12:45:28 -0700
> To: cvs...@li...
> From: bw...@us...
> Subject: [Cvs-syncmail] CVSROOT syncmail,1.10,1.11
>
> Update of /cvsroot/cvs-syncmail/CVSROOT
> In directory usw-pr-cvs1:/tmp/cvs-serv11428
>
> Modified Files:
> 	syncmail 
> Log Message:
> Sebastian Ude's patch to include the realname of the developer

That was fast :).

But didn't you forget to add

'name' : name

here:


> +''' % {'address' : address,
> +       'people'  : string.join(people, COMMASPACE),
> +       'subject' : subject,
> +       'version' : __version__,
>         }


- Sebastian

Re: [Cvs-syncmail] CVSROOT syncmail,1.10,1.11

[<ba...@zo...>]

>>>>> "SU" == Sebastian Ude <ud...@ha...> writes:

    SU> That was fast :).

    SU> But didn't you forget to add

    SU> 'name' : name

Indeed, you just haven't gotten the next checkin msg yet! :)

Boy, debugging this thing in-situ /really/ sucks.
-Barry

Re: [Cvs-syncmail] CVSROOT syncmail,1.10,1.11

[Sebastian U. <ud...@ha...>]

On Thu, 23 May 2002, ba...@zo... (Barry A. Warsaw) wrote:
> Date: Thu, 23 May 2002 15:56:51 -0400
> To: ud...@ha...
> From: ba...@zo... (Barry A. Warsaw)
> CC: cvs...@li...
> Subject: Re: [Cvs-syncmail] CVSROOT syncmail,1.10,1.11
>
>
> >>>>> "SU" == Sebastian Ude <ud...@ha...> writes:
>
>     SU> That was fast :).
>
>     SU> But didn't you forget to add
>
>     SU> 'name' : name
>
> Indeed, you just haven't gotten the next checkin msg yet! :)

I can guess why :).


> Boy, debugging this thing in-situ /really/ sucks.

Yep.


- Sebastian

Re: [Cvs-syncmail] CVSROOT syncmail,1.10,1.11

[<ba...@zo...>]

>>>>> "SU" == Sebastian Ude <ud...@ha...> writes:

    SU> I can guess why :).

Heh, I finally just installed it on my local cvs repository and
debugged it there (by spewing to a /tmp log file).

    >> Boy, debugging this thing in-situ /really/ sucks.

    SU> Yep.

Did I mention that debugging syncmail in-situ /really/ sucks?

:)

Anyway, what's in cvs now should be working.  Thanks for the patch.

-Barry

BTW, next time, please use the cvs-syncmail project's patch manager!
It'll make sure stuff like this doesn't get buried in our inboxes.

Re: [Cvs-syncmail] CVSROOT syncmail,1.10,1.11

[Sebastian U. <ud...@ha...>]

On Thu, 23 May 2002, ba...@zo... (Barry A. Warsaw) wrote:
> Date: Thu, 23 May 2002 16:27:35 -0400
> To: ud...@ha...
> From: ba...@zo... (Barry A. Warsaw)
> CC: cvs...@li...
> Subject: Re: [Cvs-syncmail] CVSROOT syncmail,1.10,1.11

[...]

> BTW, next time, please use the cvs-syncmail project's patch manager!
> It'll make sure stuff like this doesn't get buried in our inboxes.

Okay - no problem.


- Sebastian

Re: [Cvs-syncmail] CVSROOT syncmail,1.10,1.11

[Fred L. D. Jr. <fd...@ac...>]

bw...@us... writes:
 > Sebastian Ude's patch to include the realname of the developer
...
 > +        name = pwd.getpwuid(os.getuid())[4]
...
 > +From: %(name)s <%(address)s>

This doesn't look right.  It doesn't deal with users who have commas
in their names (like me).


  -Fred

-- 
Fred L. Drake, Jr.  <fdrake at acm.org>
PythonLabs at Zope Corporation

Re: [Cvs-syncmail] CVSROOT syncmail,1.10,1.11

[Sebastian U. <ud...@ha...>]

On Fri, 24 May 2002, fd...@ac... (Fred L. Drake, Jr.) wrote:
> Date: Fri, 24 May 2002 12:11:20 -0400
> To: bw...@us...
> From: fd...@ac... (Fred L. Drake, Jr.)
> CC: cvs...@li...
> Subject: Re: [Cvs-syncmail] CVSROOT syncmail,1.10,1.11
>
>
> bw...@us... writes:
>  > Sebastian Ude's patch to include the realname of the developer
> ....
>  > +        name = pwd.getpwuid(os.getuid())[4]
> ....
>  > +From: %(name)s <%(address)s>
>
> This doesn't look right.  It doesn't deal with users who have commas
> in their names (like me).

Mhm ...

Do you have a better suggestion ?


- Sebastian

Re: [Cvs-syncmail] CVSROOT syncmail,1.10,1.11

[Fred L. D. Jr. <fd...@ac...>]

Barry's patch included:
 > +From: %(name)s <%(address)s>

I commented:
 > This doesn't look right.  It doesn't deal with users who have commas
 > in their names (like me).

Sebastian Ude writes:
 > Do you have a better suggestion ?

How about:

 From: "%(name)s" <%(address)s>

(indented to hide from overly-cautious mail systems)

That form of quoting seems to work for just about anything in
practice.


  -Fred

-- 
Fred L. Drake, Jr.  <fdrake at acm.org>
PythonLabs at Zope Corporation