cvs-syncmail-talk — User & developer discussions for the "syncmail" CVS checkin notification tool

[Cvs-syncmail] Avoiding CVS lock in syncmail

[Fred L. D. Jr. <fd...@ac...>]

After hacking up a commitinfo script yesterday, it occurred to me that
syncmail should be able to use "rcsdiff" instead of "cvs diff" to
generate diffs, and not run afoul of the CVS lock.  Perhaps the
backgrounding of syncmail could be avoided.

If anyone has time on their hands ;-) it might make a nice project to
see what can be done.


  -Fred

-- 
Fred L. Drake, Jr.  <fdrake at acm.org>
PythonLabs at Zope Corporation

[Cvs-syncmail] Re: Bug#168832: cvs-syncmail: doesn't work.

[Neil S. <ns...@cs...>]

On Tue, Nov 12, 2002 at 04:34:47PM -0700, Kevin Rosenberg wrote:
> Hello cvs-syncmail guys,

> The Debian cvs-syncmail package has already gotten a new user. Neil
> Spring had confusion reading the output of --help and he put %s as the
> argument to syncmail. He proposes adding some more information to that
> output, perhaps along the lines of what he wrote below to help
> others who
> might be led astry.

I actually would prefer the five-character change to modify
the example at the top of the output from:
    mymodule /path/to/this/script %s som...@yo...main
to:
    mymodule /path/to/this/script %{sVv} som...@yo...main

The rest was a tongue-in-cheek comment after being told to
RTFM.

thanks,
-neil

[Cvs-syncmail] Re: Bug#168832: cvs-syncmail: doesn't work.

[Kevin R. <ke...@ro...>]

Hello cvs-syncmail guys,

The Debian cvs-syncmail package has already gotten a new user. Neil
Spring had confusion reading the output of --help and he put %s as the
argument to syncmail. He proposes adding some more information to that
output, perhaps along the lines of what he wrote below to help others who
might be led astry.
 
Best,

-- 
       Kevin Rosenberg        |  .''`.  ** Debian GNU/Linux **
  http://b9.com/debian.html   | : :' :      The  universal
  GPG signed and encrypted    | `. `'      Operating System
     messages accepted.       |   `-    http://www.debian.org/


Neil Spring wrote:
>  If the %s in the loginfo file is not %{sVv}, syncmail
>  will fail miserably with error messages you won't 
>  understand, making the example at the top of this file 
>  confusing and useless.  So be sure to ignore the example
>  at the top of this message and instead use: 
>  mymodule /usr/bin/syncmail %{sVv} som...@yo...main.
> 
> > Which would have been more clear.  
> 
> All I'm asking is that the example at the top (well outside
> the "usage" statement) be made usable.

[Cvs-syncmail] syncmail syncmail,1.23,1.24

[Greg W. <gw...@us...>]

Update of /cvsroot/cvs-syncmail/syncmail
In directory usw-pr-cvs1:/tmp/cvs-serv3279

Modified Files:
	syncmail 
Log Message:
Add quotename() and rfc822_specials_re so we only quote real names
in the "From" header when we really need to.  Fixes SF bug #592836.


Index: syncmail
===================================================================
RCS file: /cvsroot/cvs-syncmail/syncmail/syncmail,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -d -r1.23 -r1.24
--- syncmail	8 Nov 2002 22:01:36 -0000	1.23
+++ syncmail	11 Nov 2002 17:42:07 -0000	1.24
@@ -223,6 +223,16 @@
 
 
 
+rfc822_specials_re = re.compile(r'[\(\)\<\>\@\,\;\:\\\"\.\[\]]')
+
+def quotename(name):
+    if name and rfc822_specials_re.search(name):
+        return '"%s"' % name.replace('"', '\\"')
+    else:
+        return name
+
+
+
 def blast_mail(subject, people, filestodiff, contextlines, fromhost, replyto):
     # cannot wait for child process or that will cause parent to retain cvs
     # lock for too long.  Urg!
@@ -241,13 +251,13 @@
         sys.stdout = s
         try:
             vars = {'address' : address,
-                    'name'    : name,
+                    'name'    : quotename(name),
                     'people'  : string.join(people, COMMASPACE),
                     'subject' : subject,
                     'version' : __version__,
                     }
             print '''\
-From: "%(name)s" <%(address)s>
+From: %(name)s <%(address)s>
 To: %(people)s''' % vars
             if replyto:
                 print 'Reply-To: %s' % replyto

Re: [Cvs-syncmail] What is cvs-syncmail's license?

[Greg W. <gw...@py...>]

On 08 November 2002, Barry A. Warsaw said:
>     KR> The PSF License looks fine. On the other hand, it is very
>     KR> similar to a BSD license except that the copyright is owned by
>     KR> the PSF. Rather that going through the efforts of assigning
>     KR> copyrights, perhaps sometime like the below would be
>     KR> acceptable.
> 
> I'd be happy with that.  It's in the spirit of the original Python
> license.  Fred, Greg, and Zooko, what do you guys think?

Whatever.  As long as it's open source I don't much care.

        Greg
-- 
Greg Ward <gw...@py...>                         http://www.gerg.ca/
I have the power to HALT PRODUCTION on all TEENAGE SEX COMEDIES!!

Re: [Cvs-syncmail] What is cvs-syncmail's license?

[Kevin R. <ke...@ro...>]

Barry A. Warsaw wrote:
> I'm going to make a leap of faith and assume Greg's on board with the
> BSD-ish license. ;) I just checked in a LICENSE file and added
> copyright notices to the file.  I hope that'll be enough for Kevin to
> add it to Debian.

Great -- I'm very happy to be able to redistribute this very helpful
product.

> I stil want to leave open the possibility of PSF donation, if the PSF
> ever starts accepting such things. ;)

Since you own the copyright, you can always change the licensing on
any time. Of course, copies of your software distributed with the
current license stay with the current license. But, that doesn't
affect your ability to relicense or to assign your copyright.

Thanks very much for your gift.

-- 
       Kevin Rosenberg        |  .''`.  ** Debian GNU/Linux **
  http://b9.com/debian.html   | : :' :      The  universal
  GPG signed and encrypted    | `. `'      Operating System
     messages accepted.       |   `-    http://www.debian.org/

Re: [Cvs-syncmail] What is cvs-syncmail's license?

[<ba...@py...>]

I'm going to make a leap of faith and assume Greg's on board with the
BSD-ish license. ;) I just checked in a LICENSE file and added
copyright notices to the file.  I hope that'll be enough for Kevin to
add it to Debian.

I stil want to leave open the possibility of PSF donation, if the PSF
ever starts accepting such things. ;)

-Barry

[Cvs-syncmail] syncmail README,1.1,1.2

[Barry W. <bw...@us...>]

Update of /cvsroot/cvs-syncmail/syncmail
In directory usw-pr-cvs1:/tmp/cvs-serv5668

Modified Files:
	README 
Log Message:
Add a copyright notice and a pointer to the LICENSE file.  I really
don't want to include the whole LICENSE file as a comment in this
file.


Index: README
===================================================================
RCS file: /cvsroot/cvs-syncmail/syncmail/README,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -d -r1.1 -r1.2
--- README	3 May 2002 21:30:23 -0000	1.1
+++ README	8 Nov 2002 22:02:25 -0000	1.2
@@ -13,5 +13,7 @@
 
     cvs...@li...
 
+See the LICENSE file for copyright information.
+
 Our thanks to Zooko for helping improve the security of the script.
 -Barry Warsaw & Fred Drake (maintainers)

[Cvs-syncmail] syncmail syncmail,1.22,1.23

[Barry W. <bw...@us...>]

Update of /cvsroot/cvs-syncmail/syncmail
In directory usw-pr-cvs1:/tmp/cvs-serv5419

Modified Files:
	syncmail 
Log Message:
Add a copyright notice and a pointer to the LICENSE file.  I really
don't want to include the whole LICENSE file as a comment in this
file.


Index: syncmail
===================================================================
RCS file: /cvsroot/cvs-syncmail/syncmail/syncmail,v
retrieving revision 1.22
retrieving revision 1.23
diff -u -d -r1.22 -r1.23
--- syncmail	7 Nov 2002 15:02:10 -0000	1.22
+++ syncmail	8 Nov 2002 22:01:36 -0000	1.23
@@ -1,5 +1,9 @@
 #! /usr/bin/python
 
+# Copyright (c) 2002, Barry Warsaw, Fred Drake, and contributors
+# All rights reserved.
+# See the accompanying LICENSE file for details.
+
 # NOTE: Until SourceForge installs a modern version of Python on the cvs
 # servers, this script MUST be compatible with Python 1.5.2.
 

[Cvs-syncmail] syncmail LICENSE,NONE,1.1

[Barry W. <bw...@us...>]

Update of /cvsroot/cvs-syncmail/syncmail
In directory usw-pr-cvs1:/tmp/cvs-serv4495

Added Files:
	LICENSE 
Log Message:
A BSD-ish license.


--- NEW FILE: LICENSE ---
Copyright (c) 2002, Barry Warsaw, Fred Drake, and contributors
All rights reserved.

Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
met:

    * Redistributions of source code must retain the above copyright
      notice, this list of conditions and the following disclaimer.
    * Redistributions in binary form must reproduce the above
      copyright notice, this list of conditions and the following
      disclaimer in the documentation and/or other materials provided
      with the distribution.
    * Neither the names of the authors nor the names of its
      contributors may be used to endorse or promote products derived
      from this software without specific prior written permission.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

Re: [Cvs-syncmail] What is cvs-syncmail's license?

[Fred L. D. Jr. <fd...@ac...>]

Barry A. Warsaw writes:
 > I'd be happy with that.  It's in the spirit of the original Python
 > license.  Fred, Greg, and Zooko, what do you guys think?

I'm fine with a BSDish license.


  -Fred

-- 
Fred L. Drake, Jr.  <fdrake at acm.org>
PythonLabs at Zope Corporation

Re: [Cvs-syncmail] What is cvs-syncmail's license?

[Zooko <zo...@zo...>]

> I'd be happy with that.  It's in the spirit of the original Python
> license.  Fred, Greg, and Zooko, what do you guys think?

+1 on BSD-ish license

Re: [Cvs-syncmail] What is cvs-syncmail's license?

[<ba...@zo...>]

>>>>> "KR" == Kevin Rosenberg <ke...@ro...> writes:

    >> We certainly could donate syncmail to the PSF, but there (still
    >> :( ) isn't a really great mechanism for doing.  The best that's
    >> out there is a proposed contribution form:
    >> http://www.python.org/psf/psf-contributor-agreement.html

    KR> I'm not familiar with other software that has had copyrights
    KR> assigned to the PSF, but I suspect that it has happed.

You might be wrong about that. ;)

    KR> The PSF License looks fine. On the other hand, it is very
    KR> similar to a BSD license except that the copyright is owned by
    KR> the PSF. Rather that going through the efforts of assigning
    KR> copyrights, perhaps sometime like the below would be
    KR> acceptable.

I'd be happy with that.  It's in the spirit of the original Python
license.  Fred, Greg, and Zooko, what do you guys think?

    KR> Thanks again for discussing this. I hope that a license is
    KR> chosen soon so that I can add your fine product to the Debian
    KR> distribution.

-Barry

Re: [Cvs-syncmail] What is cvs-syncmail's license?

[Kevin R. <ke...@ro...>]

Barry A. Warsaw wrote:
> I'm nearly positive I chose "Python license" when I set up the
> project.  Certainly the intent was to put a Pythonic license on the
> thing, and perhaps eventually donate it to the PSF.

Hi Barry, thanks for the reply.

> Unfortunately, if you actually read the PSF license for Python, it's
> pretty specific to Python and the fact that the PSF is the entity that
> is actually doing the licensing.  It doesn't really apply out of the
> box to syncmail.

Yeah, I saw that.

> We certainly could donate syncmail to the PSF, but there (still :(
> ) isn't a really great mechanism for doing.  The best that's out there
> is a proposed contribution form:
> 
>     http://www.python.org/psf/psf-contributor-agreement.html

I'm not familiar with other software that has had copyrights assigned
to the PSF, but I suspect that it has happed.

> BTW, I brought this up on the PSF mailing lists back in May, specific
> for syncmail.  Like too many other things, we lost interest and the
> thread died without traction (I blame myself for that).  At the time,
> I proposed the following license.  Note that that it would require
> donating the software to the PSF, and then there's the question of who
> would need to do the donating (everyone who's committed changes to the
> code, just me, etc...)

The PSF License looks fine. On the other hand, it is very similar to a
BSD license except that the copyright is owned by the PSF. Rather that
going through the efforts of assigning copyrights, perhaps sometime
like the below would be acceptable.

Thanks again for discussing this. I hope that a license is chosen soon
so that I can add your fine product to the Debian distribution.

-- 
       Kevin Rosenberg        |  .''`.  ** Debian GNU/Linux **
  http://b9.com/debian.html   | : :' :      The  universal
  GPG signed and encrypted    | `. `'      Operating System
     messages accepted.       |   `-    http://www.debian.org/


Copyright (C) Barry Warsaw, Fred Drake, and contributors.

Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions
are met:
1. Redistributions of source code must retain the above copyright
   notice, this list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above copyright
   notice, this list of conditions and the following disclaimer in the
   documentation and/or other materials provided with the distribution.
3. The name of the author may not be used to endorse or promote products
   derived from this software without specific prior written
   permission.

THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS
BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE
OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN
IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

Re: [Cvs-syncmail] What is cvs-syncmail's license?

[<ba...@zo...>]

>>>>> "Fred" == Fred L Drake, Jr <fd...@ac...> writes:

    >> I started usign cvs-syncmail and I like it a lot. I'd like to
    >> package this for the Debian GNU/Linux distribution. I see a
    >> copyright in docs/syncmail.sgml, but there is no license that
    >> specifies rights of use or redistribution for
    >> cvs-syncmail. Without such a license, I can't distribute
    >> cvs-syncmail as a Debian package.

    Fred> I don't think we've ever really talked much about the
    Fred> license for syncmail, and I'm not sure where to find what
    Fred> license information was provided to SourceForge.  Barry, do
    Fred> you remember how you set it up?

I'm nearly positive I chose "Python license" when I set up the
project.  Certainly the intent was to put a Pythonic license on the
thing, and perhaps eventually donate it to the PSF.

    Fred> If no one can remember what the license is, I'll propose we
    Fred> stick the PSF license on it.  ;-)

Unfortunately, if you actually read the PSF license for Python, it's
pretty specific to Python and the fact that the PSF is the entity that
is actually doing the licensing.  It doesn't really apply out of the
box to syncmail.

We certainly could donate syncmail to the PSF, but there (still :(
) isn't a really great mechanism for doing.  The best that's out there
is a proposed contribution form:

    http://www.python.org/psf/psf-contributor-agreement.html

BTW, I brought this up on the PSF mailing lists back in May, specific
for syncmail.  Like too many other things, we lost interest and the
thread died without traction (I blame myself for that).  At the time,
I proposed the following license.  Note that that it would require
donating the software to the PSF, and then there's the question of who
would need to do the donating (everyone who's committed changes to the
code, just me, etc...)

-Barry

-------------------- snip snip --------------------
PSF LICENSE AGREEMENT 1.0
-------------------------

1. This LICENSE AGREEMENT is between the Python Software Foundation
("PSF"), and the Individual or Organization ("Licensee") accessing and
otherwise using PSF software ("the Software") in source or binary form
and its associated documentation.

2. Subject to the terms and conditions of this License Agreement, PSF
hereby grants Licensee a nonexclusive, royalty-free, world-wide
license to reproduce, analyze, test, perform and/or display publicly,
prepare derivative works, distribute, and otherwise use the Software
alone or in any derivative version, provided, however, that PSF's
License Agreement and PSF's notice of copyright are retained in the
Software alone or in any derivative version prepared by Licensee.

3. In the event Licensee prepares a derivative work that is based on
or incorporates the Software or any part thereof, and wants to make
the derivative work available to others as provided herein, then
Licensee hereby agrees to include in any such work a brief summary of
the changes made to the Software.

4. PSF is making the Software available to Licensee on an "AS IS"
basis.  PSF MAKES NO REPRESENTATIONS OR WARRANTIES, EXPRESS OR
IMPLIED.  BY WAY OF EXAMPLE, BUT NOT LIMITATION, PSF MAKES NO AND
DISCLAIMS ANY REPRESENTATION OR WARRANTY OF MERCHANTABILITY OR FITNESS
FOR ANY PARTICULAR PURPOSE OR THAT THE USE OF THE SOFTWARE WILL NOT
INFRINGE ANY THIRD PARTY RIGHTS.

5. PSF SHALL NOT BE LIABLE TO LICENSEE OR ANY OTHER USERS OF THE
SOFTWARE FOR ANY INCIDENTAL, SPECIAL, OR CONSEQUENTIAL DAMAGES OR LOSS
AS A RESULT OF MODIFYING, DISTRIBUTING, OR OTHERWISE USING THE
SOFTWARE, OR ANY DERIVATIVE THEREOF, EVEN IF ADVISED OF THE
POSSIBILITY THEREOF.

6. This License Agreement will automatically terminate upon a material
breach of its terms and conditions.

7. Nothing in this License Agreement shall be deemed to create any
relationship of agency, partnership, or joint venture between PSF and
Licensee.  This License Agreement does not grant permission to use PSF
trademarks or trade name in a trademark sense to endorse or promote
products or services of Licensee, or any third party.

8. By copying, installing or otherwise using the Software, Licensee
agrees to be bound by the terms and conditions of this License
Agreement.

Re: [Cvs-syncmail] What is cvs-syncmail's license?

[Fred L. D. Jr. <fd...@ac...>]

Kevin Rosenberg writes:
 > I started usign cvs-syncmail and I like it a lot. I'd like to package
 > this for the Debian GNU/Linux distribution. I see a copyright in
 > docs/syncmail.sgml, but there is no license that specifies rights of
 > use or redistribution for cvs-syncmail. Without such a license, I
 > can't distribute cvs-syncmail as a Debian package.

I don't think we've ever really talked much about the license for
syncmail, and I'm not sure where to find what license information was
provided to SourceForge.  Barry, do you remember how you set it up?

If no one can remember what the license is, I'll propose we stick the
PSF license on it.  ;-)


  -Fred

-- 
Fred L. Drake, Jr.  <fdrake at acm.org>
PythonLabs at Zope Corporation

[Cvs-syncmail] What is cvs-syncmail's license?

[Kevin R. <ke...@ro...>]

Hello CVS-Syncmail list,

I started usign cvs-syncmail and I like it a lot. I'd like to package
this for the Debian GNU/Linux distribution. I see a copyright in
docs/syncmail.sgml, but there is no license that specifies rights of
use or redistribution for cvs-syncmail. Without such a license, I
can't distribute cvs-syncmail as a Debian package.

What is the license for cvs-syncmail?

Thanks for your time and the excellent tool.

--
       Kevin Rosenberg        |  .''`.  ** Debian GNU/Linux **
  http://b9.com/debian.html   | : :' :      The  universal
  GPG signed and encrypted    | `. `'      Operating System
     messages accepted.       |   `-    http://www.debian.org/

Re: [Cvs-syncmail] Patch: fix bug #592836

[Greg W. <gw...@py...>]

On 29 October 2002, I said:
> While I'm in the mood, here's another patch for syncmail.  This one
> fixes bug #592836

Here's a revised version of that patch, relative to current CVS:

--- syncmail	7 Nov 2002 15:02:10 -0000	1.22
+++ syncmail	7 Nov 2002 15:04:36 -0000
@@ -219,6 +219,16 @@
 
 
 
+rfc822_specials_re = re.compile(r'[\(\)\<\>\@\,\;\:\\\"\.\[\]]')
+
+def quotename(name):
+    if name and rfc822_specials_re.search(name):
+        return '"%s"' % name.replace('"', '\\"')
+    else:
+        return name
+
+
+
 def blast_mail(subject, people, filestodiff, contextlines, fromhost, replyto):
     # cannot wait for child process or that will cause parent to retain cvs
     # lock for too long.  Urg!
@@ -237,13 +247,13 @@
         sys.stdout = s
         try:
             vars = {'address' : address,
-                    'name'    : name,
+                    'name'    : quotename(name),
                     'people'  : string.join(people, COMMASPACE),
                     'subject' : subject,
                     'version' : __version__,
                     }
             print '''\
-From: "%(name)s" <%(address)s>
+From: %(name)s <%(address)s>
 To: %(people)s''' % vars
             if replyto:
                 print 'Reply-To: %s' % replyto


Barry already said +1 for this, so I'm going to test it out in real life
and then check this change in.

        Greg
-- 
Greg Ward <gw...@py...>                         http://www.gerg.ca/
I don't believe there really IS a GAS SHORTAGE.. I think it's all just
a BIG HOAX on the part of the plastic sign salesmen -- to sell more numbers!!

Re: [Cvs-syncmail] Patch: add Reply-To header

[Greg W. <gw...@py...>]

On 07 November 2002, Barry A. Warsaw said:
>     GW> OK, I finally got around to actually testing my second attempt
>     GW> at the "add Reply-To" patch.  It worked.
> 
>     GW> Barry, can I check this in now?
> 
> +1

OK, my "reply-to" patch is checked in.

        Greg

[Cvs-syncmail] syncmail syncmail,1.21,1.22

[Greg W. <gw...@us...>]

Update of /cvsroot/cvs-syncmail/syncmail
In directory usw-pr-cvs1:/tmp/cvs-serv19163

Modified Files:
	syncmail 
Log Message:
Added -R/--reply-to option, and extended blast_mail() accordingly.


Index: syncmail
===================================================================
RCS file: /cvsroot/cvs-syncmail/syncmail/syncmail,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -d -r1.21 -r1.22
--- syncmail	19 Sep 2002 19:30:15 -0000	1.21
+++ syncmail	7 Nov 2002 15:02:10 -0000	1.22
@@ -51,6 +51,10 @@
     --subject-prefix=TEXT
         Prepend TEXT to the email subject line.
 
+    -R ADDR
+    --reply-to=ADDR
+      Add a "Reply-To: ADDR" header to the email message.
+
     --quiet / -q
         Don't print as much status to stdout.
 
@@ -215,7 +219,7 @@
 
 
 
-def blast_mail(subject, people, filestodiff, contextlines, fromhost):
+def blast_mail(subject, people, filestodiff, contextlines, fromhost, replyto):
     # cannot wait for child process or that will cause parent to retain cvs
     # lock for too long.  Urg!
     if not os.fork():
@@ -232,17 +236,21 @@
         s = StringIO()
         sys.stdout = s
         try:
+            vars = {'address' : address,
+                    'name'    : name,
+                    'people'  : string.join(people, COMMASPACE),
+                    'subject' : subject,
+                    'version' : __version__,
+                    }
             print '''\
 From: "%(name)s" <%(address)s>
-To: %(people)s
+To: %(people)s''' % vars
+            if replyto:
+                print 'Reply-To: %s' % replyto
+            print '''\
 Subject: %(subject)s
 X-Mailer: Python syncmail %(version)s <http://sf.net/projects/cvs-syncmail>
-''' % {'address' : address,
-       'name'    : name,
-       'people'  : string.join(people, COMMASPACE),
-       'subject' : subject,
-       'version' : __version__,
-       }
+''' % vars
             s.write(sys.stdin.read())
             # append the diffs if available
             print
@@ -260,8 +268,9 @@
 def main():
     try:
         opts, args = getopt.getopt(
-            sys.argv[1:], 'hC:cuS:qf:',
-            ['fromhost=', 'context=', 'cvsroot=', 'subject-prefix=',
+            sys.argv[1:], 'hC:cuS:R:qf:',
+            ['fromhost=', 'context=', 'cvsroot=',
+             'subject-prefix=', 'reply-to=',
              'help', 'quiet'])
     except getopt.error, msg:
         usage(1, msg)
@@ -270,6 +279,7 @@
     contextlines = 2
     verbose = 1
     subject_prefix = ""
+    replyto = None
     fromhost = None
     for opt, arg in opts:
         if opt in ('-h', '--help'):
@@ -285,6 +295,8 @@
             contextlines = 0
         elif opt in ('-S', '--subject-prefix'):
             subject_prefix = arg
+        elif opt in ('-R', '--reply-to'):
+            replyto = arg
         elif opt in ('-q', '--quiet'):
             verbose = 0
         elif opt in ('-f', '--fromhost'):
@@ -326,7 +338,7 @@
 
     if verbose:
         print 'Generating notification message...'
-    blast_mail(subject, people, specs[1:], contextlines, fromhost)
+    blast_mail(subject, people, specs[1:], contextlines, fromhost, replyto)
     if verbose:
         print 'Generating notification message... done.'
 

Re: [Cvs-syncmail] Patch: add Reply-To header

[<ba...@zo...>]

>>>>> "GW" == Greg Ward <gw...@py...> writes:

    GW> On 29 October 2002, I said:
    >> Second attempt at the patch (unlike the last attempt, I haven't
    >> tested this one):

    GW> OK, I finally got around to actually testing my second attempt
    GW> at the "add Reply-To" patch.  It worked.

    GW> Barry, can I check this in now?

+1

-Barry

Re: [Cvs-syncmail] Patch: add Reply-To header

[Greg W. <gw...@py...>]

On 29 October 2002, I said:
> Second attempt at the patch (unlike the last attempt, I haven't tested
> this one):

OK, I finally got around to actually testing my second attempt at the
"add Reply-To" patch.  It worked.

Barry, can I check this in now?

        Greg
-- 
Greg Ward <gw...@py...>                         http://www.gerg.ca/
God is omnipotent, omniscient, and omnibenevolent
---it says so right here on the label.

Re: [Cvs-syncmail] Patch: add Reply-To header

[Greg W. <gw...@py...>]

On 29 October 2002, Barry A. Warsaw said:
> Except the patch also gets rid of the multiline string, which is a
> style I find more readable than multiple prints.  +1 if you fix that
> <wink>.

Damn, I was hoping I could subtly persuade you that, for cases where the
string exceeds a certain threshold of variability, multiple prints work
better.  (In particular, I don't like redundant "Reply-To", so I want to
suppress it if -R wasn't supplied -- IMHO that makes this string
variable enough.)

Second attempt at the patch (unlike the last attempt, I haven't tested
this one):

--- syncmail	19 Sep 2002 19:30:15 -0000	1.21
+++ syncmail	29 Oct 2002 20:56:26 -0000
@@ -51,6 +51,10 @@
     --subject-prefix=TEXT
         Prepend TEXT to the email subject line.
 
+    -R ADDR
+    --reply-to=ADDR
+      Add a "Reply-To: ADDR" header to the email message.
+
     --quiet / -q
         Don't print as much status to stdout.
 
@@ -215,7 +219,7 @@
 
 
 
-def blast_mail(subject, people, filestodiff, contextlines, fromhost):
+def blast_mail(subject, people, filestodiff, contextlines, fromhost, replyto):
     # cannot wait for child process or that will cause parent to retain cvs
     # lock for too long.  Urg!
     if not os.fork():
@@ -232,17 +236,21 @@
         s = StringIO()
         sys.stdout = s
         try:
+            vars = {'address' : address,
+                    'name'    : name,
+                    'people'  : string.join(people, COMMASPACE),
+                    'subject' : subject,
+                    'version' : __version__,
+                    }
             print '''\
 From: "%(name)s" <%(address)s>
-To: %(people)s
+To: %(people)s''' % vars
+            if replyto:
+                print 'Reply-To: %s' % replyto
+            print '''\
 Subject: %(subject)s
 X-Mailer: Python syncmail %(version)s <http://sf.net/projects/cvs-syncmail>
-''' % {'address' : address,
-       'name'    : name,
-       'people'  : string.join(people, COMMASPACE),
-       'subject' : subject,
-       'version' : __version__,
-       }
+''' % vars
             s.write(sys.stdin.read())
             # append the diffs if available
             print
@@ -260,8 +268,9 @@
 def main():
     try:
         opts, args = getopt.getopt(
-            sys.argv[1:], 'hC:cuS:qf:',
-            ['fromhost=', 'context=', 'cvsroot=', 'subject-prefix=',
+            sys.argv[1:], 'hC:cuS:R:qf:',
+            ['fromhost=', 'context=', 'cvsroot=',
+             'subject-prefix=', 'reply-to=',
              'help', 'quiet'])
     except getopt.error, msg:
         usage(1, msg)
@@ -270,6 +279,7 @@
     contextlines = 2
     verbose = 1
     subject_prefix = ""
+    replyto = None
     fromhost = None
     for opt, arg in opts:
         if opt in ('-h', '--help'):
@@ -285,6 +295,8 @@
             contextlines = 0
         elif opt in ('-S', '--subject-prefix'):
             subject_prefix = arg
+        elif opt in ('-R', '--reply-to'):
+            replyto = arg
         elif opt in ('-q', '--quiet'):
             verbose = 0
         elif opt in ('-f', '--fromhost'):
@@ -326,7 +338,7 @@
 
     if verbose:
         print 'Generating notification message...'
-    blast_mail(subject, people, specs[1:], contextlines, fromhost)
+    blast_mail(subject, people, specs[1:], contextlines, fromhost, replyto)
     if verbose:
         print 'Generating notification message... done.'
 

-- 
Greg Ward <gw...@py...>                         http://www.gerg.ca/
I don't believe there really IS a GAS SHORTAGE.. I think it's all just
a BIG HOAX on the part of the plastic sign salesmen -- to sell more numbers!!

Re: [Cvs-syncmail] Patch: fix bug #592836

[<ba...@zo...>]

>>>>> "GW" == Greg Ward <gw...@py...> writes:

    GW> While I'm in the mood, here's another patch for syncmail.
    GW> This one fixes bug #592836, which complains about syncmail
    GW> generating "From:" headers like

    GW>   From: "" <us...@so...main>

    GW> -- apparently some mail clients don't like that.  And besides,
    GW> it's ugly.  This patch fixes syncmail to only quote names when
    GW> they actually need to be quoted, ie. when they contain RFC 822
    GW> "special" characters.  This patch is relative to the
    GW> "reply-to" patch I just posted.

+1

Re: [Cvs-syncmail] Patch: add Reply-To header

[<ba...@zo...>]

>>>>> "GW" == Greg Ward <gw...@py...> writes:

    GW> Here's a patch to syncmail that adds a -R/--reply-to option,
    GW> which makes syncmail add a "Reply-To" header to the email
    GW> message.  IMHO this is long overdue -- it makes perfect sense
    GW> for replies to foo-checkins to be directed at foo-devel, and
    GW> this is the obvious way to do it.

    GW> Anyone object?  Or shall I go ahead and check this in?

Except the patch also gets rid of the multiline string, which is a
style I find more readable than multiple prints.  +1 if you fix that
<wink>.

-Barry