cvs-syncmail-talk — User & developer discussions for the "syncmail" CVS checkin notification tool

[Cvs-syncmail] syncmail syncmail,1.36.2.19,1.36.2.20

[Fred L. D. Jr. <fd...@us...>]

Update of /cvsroot/cvs-syncmail/syncmail
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv8531

Modified Files:
      Tag: new-config-branch
	syncmail 
Log Message:
drop direct use of rcsdiff; this doesn't work so well


Index: syncmail
===================================================================
RCS file: /cvsroot/cvs-syncmail/syncmail/syncmail,v
retrieving revision 1.36.2.19
retrieving revision 1.36.2.20
diff -u -d -r1.36.2.19 -r1.36.2.20
--- syncmail	19 Apr 2004 17:58:10 -0000	1.36.2.19
+++ syncmail	12 Oct 2004 18:54:27 -0000	1.36.2.20
@@ -219,9 +219,8 @@
             difftype = "-C %d" % config.contextlines
         else:
             difftype = "-u"
-        rcsfile = get_rcs_file(config, file)
-        diffcmd = "/usr/bin/rcsdiff -kk %s --minimal -r %s -r %s %s" \
-                  % (difftype, oldrev, newrev, filestr(rcsfile))
+        diffcmd = "/usr/bin/cvs -f diff -kk %s --minimal -r %s -r %s %s" \
+                  % (difftype, oldrev, newrev, filestr(file))
         fp = os.popen(diffcmd)
         lines = fp.readlines()
         # ignore the error code, it always seems to be 1 :(
@@ -247,12 +246,6 @@
         # quote it with single-quotes.
         return "'%s'" % file
 
-def get_rcs_file(config, file):
-    fn = os.path.join(config.repodir, file)
-    if not os.path.isfile(fn):
-        fn = os.path.join(config.repodir, "Attic", file)
-    return fn
-
 
 
 rfc822_specials_re = re.compile(r'[\(\)\<\>\@\,\;\:\\\"\.\[\]]')

[Cvs-syncmail] [ cvs-syncmail-Bugs-967653 ] ImportError: cannot import name formataddr

[SourceForge.net <no...@so...>]

Bugs item #967653, was opened at 2004-06-06 12:02
Message generated for change (Comment added) made by fdrake
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450019&aid=967653&group_id=47611

Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Serguei A. Mokhov (mokhov)
>Assigned to: Fred L. Drake, Jr. (fdrake)
Summary: ImportError: cannot import name formataddr

Initial Comment:
Hello,

I have Python 2.2 installed. After upgrading to
syncmail 2.1 I started getting the below. Looks like it
cannot find 'formataddr' for some reason. Any insight
on the matter would be appreciated.

Checking in wrappers/Worker.java;
/cvsroot/gipsy/gipsy/src/gipsy/wrappers/Worker.java,v 
<--  Worker.java
new revision: 1.9; previous revision: 1.8
done
Traceback (most recent call last):
  File "/cvsroot/gipsy/CVSROOT/syncmail", line 103, in ?
    from email.Utils import formataddr
ImportError: cannot import name formataddr

-s


----------------------------------------------------------------------

>Comment By: Fred L. Drake, Jr. (fdrake)
Date: 2004-10-06 22:26

Message:
Logged In: YES 
user_id=3066

I've fixed the comment in the syncmail script (file revision
2.2 in CVS).

----------------------------------------------------------------------

Comment By: Serguei A. Mokhov (mokhov)
Date: 2004-06-07 09:00

Message:
Logged In: YES 
user_id=560391

That's what I suspected -- 2.2 is not enough, but was
misguided by the comment in the syncmail file:

# NOTE: SourceForge currently runs Python 2.2.3, so we need
to remain
# compatible with the Python 2.2 line.

This ought to change to "with the Python 2.2.2 line."

Thanks!

-s


----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2004-06-07 05:49

Message:
Logged In: NO 

formataddr was added to python v2.2.2 - syncmail will fail on 
any version before that. Sounds like you need to upgrade 
your python...

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450019&aid=967653&group_id=47611

[Cvs-syncmail] syncmail syncmail,2.1,2.2

[Fred L. D. Jr. <fd...@us...>]

Update of /cvsroot/cvs-syncmail/syncmail
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv18566

Modified Files:
	syncmail 
Log Message:
update comment noting the Python version required by syncmail
(closes SF bug #967653)


Index: syncmail
===================================================================
RCS file: /cvsroot/cvs-syncmail/syncmail/syncmail,v
retrieving revision 2.1
retrieving revision 2.2
diff -u -d -r2.1 -r2.2
--- syncmail	12 Mar 2004 22:52:26 -0000	2.1
+++ syncmail	7 Oct 2004 02:25:03 -0000	2.2
@@ -5,7 +5,8 @@
 # See the accompanying LICENSE file for details.
 
 # NOTE: SourceForge currently runs Python 2.2.3, so we need to remain
-# compatible with the Python 2.2 line.
+# compatible with at least that version.  Python 2.2.2 or newer is
+# currently required.
 
 """Complicated notification for CVS checkins.
 

[Cvs-syncmail] [ cvs-syncmail-Patches-1021987 ] suppress certain branch checkin mails

[SourceForge.net <no...@so...>]

Patches item #1021987, was opened at 2004-09-03 14:12
Message generated for change (Comment added) made by fdrake
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450021&aid=1021987&group_id=47611

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Skip Montanaro (montanaro)
Assigned to: Nobody/Anonymous (nobody)
Summary: suppress certain branch checkin mails

Initial Comment:
In our environment we have an unwritten policy that
most extensive new development occurs on development
branches, not on the trunk.  Aside from the trunk we
also have maintenance branches whose names follow a
consistent naming rule.

When development occurs over a longish period of time,
developers tend to merge from the trunk periodically so
as not to get too out-of-sync, then checkin the merge
results on the branch.  This can result in large
numbers of fairly worthless syncmail messages.

The attached patch allows you to specify a tag pattern
on the syncmail command line.  For example, all our
maintenance branches have names like snake_1_19_branch.
By giving

    -t 'snake[0-9_]+branch'

as an arg to syncmail, only checkins on the trunk or
such maintenance branches generate email output.
Merges from development branches to the trunk are seen
because all trunk checkins continue to generate email.

This certainly isn't for everyone.  I imagine it will
be most useful for small development groups with other
ways of keeping up-to-date with ongoing work in
development branches besides CVS.  For widespread open
source projects it probably doesn't make much sense.
It works for us because each development branch is the
responsibility of a single person and all developers
are within a few feet of each other.


----------------------------------------------------------------------

>Comment By: Fred L. Drake, Jr. (fdrake)
Date: 2004-10-06 22:18

Message:
Logged In: YES 
user_id=3066

I think this will be covered by the changes in the version
on the "new-config-branch" branch, but I'll leave it open
for now, since I've not reviewed that aspect of the code in
a while.

(The branch has other problems at the moment, though.)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450021&aid=1021987&group_id=47611

[Cvs-syncmail] [ cvs-syncmail-Patches-1034306 ] Too early SMTP conn w/ false timeout on strict SMTP relays

[SourceForge.net <no...@so...>]

Patches item #1034306, was opened at 2004-09-24 16:11
Message generated for change (Settings changed) made by fdrake
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450021&aid=1034306&group_id=47611

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Serguei A. Mokhov (mokhov)
Assigned to: Nobody/Anonymous (nobody)
>Summary: Too early SMTP conn w/ false timeout on strict SMTP relays

Initial Comment:
Hello,

I have encountered a situation when the SMTP
relay has the connection timeout set to 2 minutes,
which sometimes caused a timeout problem with
syncmail because of a long commit message (long as in 
long-to-type). This was happening because syncmail
used to make an SMTP connection before any message 
is actually prepared, and if it takes the user to type it 
long enough, it'll time out. So, the attached patch fixes
the problem by moving the connection establishing
down the code after the message is actually ready.

I also udated the comments on top to explicitly mention
the requirement for Python 2.2.2 rather than 2.2 because
fromataddr appeared only in 2.2.2.

Thanks.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450021&aid=1034306&group_id=47611

[Cvs-syncmail] [ cvs-syncmail-Patches-873861 ] Add option to only report commits to the CVS HEAD

[SourceForge.net <no...@so...>]

Patches item #873861, was opened at 2004-01-09 11:19
Message generated for change (Comment added) made by fdrake
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450021&aid=873861&group_id=47611

Category: None
Group: None
>Status: Closed
>Resolution: Rejected
Priority: 5
Submitted By: Sean Morrison (brlcad)
Assigned to: Nobody/Anonymous (nobody)
Summary: Add option to only report commits to the CVS HEAD

Initial Comment:
A group I work with had a particular need to ignore commits 
to CVS branches.  So, I modified our (apparently older) 
version of syncmail and added the ability to do just that.

It was a quick hack that I'm sure can be improved, as it 
relies on a format assumption of the CVS version string.  
Probably using a regexp is a bit much, just to count commas 
and periods, but my python mojo is not up to par with my 
other languages.  

A small unified diff format patch is attached.

Cheers!
Sean


----------------------------------------------------------------------

>Comment By: Fred L. Drake, Jr. (fdrake)
Date: 2004-10-06 22:09

Message:
Logged In: YES 
user_id=3066

This is a feature that already exists on the
"new-config-branch" branch in CVS.

I'm rejecting the patch in favor of finishing that branch
(I'm all for the feature, though!).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450021&aid=873861&group_id=47611

[Cvs-syncmail] [ cvs-syncmail-Patches-938197 ] Use CVS_USER if available

[SourceForge.net <no...@so...>]

Patches item #938197, was opened at 2004-04-19 17:43
Message generated for change (Comment added) made by fdrake
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450021&aid=938197&group_id=47611

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Skip Montanaro (montanaro)
Assigned to: Fred L. Drake, Jr. (fdrake)
Summary: Use CVS_USER if available

Initial Comment:
Here's a simple patch Fred requested which uses the
CVS_USER environment variable as the sender of the
mail in preference to the currently running user.


----------------------------------------------------------------------

>Comment By: Fred L. Drake, Jr. (fdrake)
Date: 2004-10-06 22:02

Message:
Logged In: YES 
user_id=3066

Off the top of my head, I can't see any reason to assume the
CVS_USER would be a system user to start with, though it may
be in many cases.

Since this is a site-admin policy matter, I'll suggest that
there be a command line option to enable this. 
Unfortunately, passing around "configuration" options like
this at this time is more than a little clunky.



----------------------------------------------------------------------

Comment By: Mike Traum (mtraum)
Date: 2004-05-06 13:02

Message:
Logged In: YES 
user_id=407536

This patch causes synvmail to fail to send an email if the
cvs user is not a system user.

----------------------------------------------------------------------

Comment By: Skip Montanaro (montanaro)
Date: 2004-04-20 18:26

Message:
Logged In: YES 
user_id=44345

Of course I hosed the diff...  second try.


----------------------------------------------------------------------

Comment By: Skip Montanaro (montanaro)
Date: 2004-04-20 18:22

Message:
Logged In: YES 
user_id=44345

Better patch -  corrects pwinfo based upon CVS_USER


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450021&aid=938197&group_id=47611

[Cvs-syncmail] Too early SMPT conn w/ false timeout on strict SMPT relays

[Serguei M. <se...@cs...>]

Hello,

[Please CC to me your replies as I am not subscribed]

I have encountered a situation when the SMTP relay has the connection
timeout set to 2 minutes, which sometimes caused a timeout problem with
syncmail because of a long commit message (long as in long-to-type). This
was happening because syncmail used to make an SMTP connection before any
message is actually prepared, and if it takes the user to type it long
enough, it'll time out. So, the attached patch fixes the problem by moving
the connection establishing down the code after the message is actually
ready.

I also udated the comments on top to explicitly mention the requirement
for Python 2.2.2 rather than 2.2 because fromataddr appeared only in
2.2.2.

Thanks.

-s

[Cvs-syncmail] [ cvs-syncmail-Patches-1034306 ] Too early SMPT conn w/ false timeout on strict SMPT relays

[SourceForge.net <no...@so...>]

Patches item #1034306, was opened at 2004-09-24 16:11
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450021&aid=1034306&group_id=47611

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Serguei A. Mokhov (mokhov)
Assigned to: Nobody/Anonymous (nobody)
Summary: Too early SMPT conn w/ false timeout on strict SMPT relays

Initial Comment:
Hello,

I have encountered a situation when the SMTP
relay has the connection timeout set to 2 minutes,
which sometimes caused a timeout problem with
syncmail because of a long commit message (long as in 
long-to-type). This was happening because syncmail
used to make an SMTP connection before any message 
is actually prepared, and if it takes the user to type it 
long enough, it'll time out. So, the attached patch fixes
the problem by moving the connection establishing
down the code after the message is actually ready.

I also udated the comments on top to explicitly mention
the requirement for Python 2.2.2 rather than 2.2 because
fromataddr appeared only in 2.2.2.

Thanks.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450021&aid=1034306&group_id=47611

[Cvs-syncmail] [ cvs-syncmail-Patches-1021987 ] suppress certain branch checkin mails

[SourceForge.net <no...@so...>]

Patches item #1021987, was opened at 2004-09-03 13:12
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450021&aid=1021987&group_id=47611

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Skip Montanaro (montanaro)
Assigned to: Nobody/Anonymous (nobody)
Summary: suppress certain branch checkin mails

Initial Comment:
In our environment we have an unwritten policy that
most extensive new development occurs on development
branches, not on the trunk.  Aside from the trunk we
also have maintenance branches whose names follow a
consistent naming rule.

When development occurs over a longish period of time,
developers tend to merge from the trunk periodically so
as not to get too out-of-sync, then checkin the merge
results on the branch.  This can result in large
numbers of fairly worthless syncmail messages.

The attached patch allows you to specify a tag pattern
on the syncmail command line.  For example, all our
maintenance branches have names like snake_1_19_branch.
By giving

    -t 'snake[0-9_]+branch'

as an arg to syncmail, only checkins on the trunk or
such maintenance branches generate email output.
Merges from development branches to the trunk are seen
because all trunk checkins continue to generate email.

This certainly isn't for everyone.  I imagine it will
be most useful for small development groups with other
ways of keeping up-to-date with ongoing work in
development branches besides CVS.  For widespread open
source projects it probably doesn't make much sense.
It works for us because each development branch is the
responsibility of a single person and all developers
are within a few feet of each other.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450021&aid=1021987&group_id=47611

[Cvs-syncmail] [ cvs-syncmail-Patches-1019485 ] colored, html mail

[SourceForge.net <no...@so...>]

Patches item #1019485, was opened at 2004-08-31 11:44
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450021&aid=1019485&group_id=47611

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Valentin Valchev (v_valchev)
Assigned to: Nobody/Anonymous (nobody)
Summary: colored, html mail

Initial Comment:
This is a patched, older version of syncmail that adds
colored diffs.

The changes are in the following routine:
blast_mail
&
calculate_diff (removed string.join() at the end of the
routine)

Two new routines added:
diff2html
htmlize

And it works.
Sorry, that the patch is for a quite old version but
it's the only one that works with my old python version.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450021&aid=1019485&group_id=47611

[Cvs-syncmail] [ cvs-syncmail-Bugs-1007677 ] Remove commas from sender's name in e-mail

[SourceForge.net <no...@so...>]

Bugs item #1007677, was opened at 2004-08-11 18:42
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450019&aid=1007677&group_id=47611

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Elliot Schwartz (esatmitdotedu)
Assigned to: Nobody/Anonymous (nobody)
Summary: Remove commas from sender's name in e-mail

Initial Comment:
On my system there are multiple sections to the name
field in  /etc/passwd, separated by commas:

elliot:x:1018:1018:Elliot
Schwartz,,,:/home/elliot:/bin/bash

When the e-mail is sent, it includes the commas:

From: Elliot Schwartz,,, <el...@mi...>

I fixed this by changing:

name = pwinfo[4]

to:

name = pwinfo[4].split(",")[0]

But maybe there's a better way to do this using the pwd
library.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450019&aid=1007677&group_id=47611

[Cvs-syncmail] [ cvs-syncmail-Bugs-1007444 ] error message on check in

[SourceForge.net <no...@so...>]

Bugs item #1007444, was opened at 2004-08-11 13:35
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450019&aid=1007444&group_id=47611

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Sam Steingold (sds)
Assigned to: Nobody/Anonymous (nobody)
Summary: error message on check in

Initial Comment:
loginfo:
ALL	/cvsroot/sitedocs/CVSROOT/cvstools/syncmail -u -f
users.sourceforge.net %{sVv}
cli...@li...


Message: Generating notification message...
Message: Traceback (most recent call last):
Message:   File
"/cvsroot/sitedocs/CVSROOT/cvstools/syncmail", line
433, in ?
Message:     main()
Message:   File
"/cvsroot/sitedocs/CVSROOT/cvstools/syncmail", line
426, in main
Message:     contextlines, fromhost, replyto)
Message:   File
"/cvsroot/sitedocs/CVSROOT/cvstools/syncmail", line
253, in blast_mail
Message:     resp = conn.sendmail(address, people,
s.getvalue())
Message:   File "/usr/lib/python2.2/smtplib.py", line
654, in sendmail
Message:     if not (200 <= self.ehlo()[0] <= 299):
Message:   File "/usr/lib/python2.2/smtplib.py", line
384, in ehlo
Message:     (code,msg)=self.getreply()
Message:   File "/usr/lib/python2.2/smtplib.py", line
335, in getreply
Message:     raise SMTPServerDisconnected("Connection
unexpectedly closed")
Message: smtplib.SMTPServerDisconnected: Connection
unexpectedly closed
Message: Mailing cli...@li......
Message: Generating notification message...
Message: Traceback (most recent call last):
Message:   File
"/cvsroot/sitedocs/CVSROOT/cvstools/syncmail", line
433, in ?
Message:     main()
Message:   File
"/cvsroot/sitedocs/CVSROOT/cvstools/syncmail", line
426, in main
Message:     contextlines, fromhost, replyto)
Message:   File
"/cvsroot/sitedocs/CVSROOT/cvstools/syncmail", line
253, in blast_mail
Message:     resp = conn.sendmail(address, people,
s.getvalue())
Message:   File "/usr/lib/python2.2/smtplib.py", line
654, in sendmail
Message:     if not (200 <= self.ehlo()[0] <= 299):
Message:   File "/usr/lib/python2.2/smtplib.py", line
384, in ehlo
Message:     (code,msg)=self.getreply()
Message:   File "/usr/lib/python2.2/smtplib.py", line
335, in getreply
Message:     raise SMTPServerDisconnected("Connection
unexpectedly closed")
Message: smtplib.SMTPServerDisconnected: Connection
unexpectedly closed


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450019&aid=1007444&group_id=47611

[Cvs-syncmail] [ cvs-syncmail-Bugs-998320 ] syncmail fails when filenames have apostrophies

[SourceForge.net <no...@so...>]

Bugs item #998320, was opened at 2004-07-26 14:38
Message generated for change (Comment added) made by dtremenak
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450019&aid=998320&group_id=47611

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Daniel Remenak (dtremenak)
Assigned to: Nobody/Anonymous (nobody)
>Summary: syncmail fails when filenames have apostrophies

Initial Comment:
Committing filenames with spaces appears to cause
syncmail problems... as shown below.  I've tried this
with a number of files for the same project, those with
spaces in the filenames are the only ones that trigger
the error.


Incorrect (note space in filename, and double "Mailing
efu...@li......"):

cvs commit -m "clarity rewording" "character-writer's
reference.txt" (in directory C:\Programs\EFUM\)
Checking in character-writer's reference.txt;
/cvsroot/efum/efum/character-writer's reference.txt,v 
<--  character-writer's reference.txt
new revision: 1.2; previous revision: 1.1
done
Mailing efu...@li......
Generating notification message...
Generating notification message... done.
Mailing efu...@li......
Generating notification message...
Traceback (most recent call last):
  File "/cvsroot/sitedocs/CVSROOT/cvstools/syncmail",
line 433, in ?
    main()
  File "/cvsroot/sitedocs/CVSROOT/cvstools/syncmail",
line 426, in main
    contextlines, fromhost, replyto)
  File "/cvsroot/sitedocs/CVSROOT/cvstools/syncmail",
line 252, in blast_mail
    print >> s, calculate_diff(entry, contextlines)
  File "/cvsroot/sitedocs/CVSROOT/cvstools/syncmail",
line 147, in calculate_diff
    filestr = filestr.replace('\', '\')
UnboundLocalError: local variable 'filestr' referenced
before assignment

Correct (no space in filename):

cvs commit -m "recent engine changes require a revision
bump" Project1.vbp (in directory C:\Programs\EFUM\)
Checking in Project1.vbp;
/cvsroot/efum/efum/Project1.vbp,v  <--  Project1.vbp
new revision: 1.13; previous revision: 1.12
done
Mailing efu...@li......
Generating notification message...
Generating notification message... done.

----------------------------------------------------------------------

>Comment By: Daniel Remenak (dtremenak)
Date: 2004-07-26 14:48

Message:
Logged In: YES 
user_id=553378

All of my files with spaces in the filename also had
apostrophies ('); just committed one with spaces but no
apostrophies and had no problems, so I'm assuming the
apostrophies are responsible.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450019&aid=998320&group_id=47611

[Cvs-syncmail] [ cvs-syncmail-Bugs-998320 ] syncmail fails when filenames have spaces

[SourceForge.net <no...@so...>]

Bugs item #998320, was opened at 2004-07-26 14:38
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450019&aid=998320&group_id=47611

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Daniel Remenak (dtremenak)
Assigned to: Nobody/Anonymous (nobody)
Summary: syncmail fails when filenames have spaces

Initial Comment:
Committing filenames with spaces appears to cause
syncmail problems... as shown below.  I've tried this
with a number of files for the same project, those with
spaces in the filenames are the only ones that trigger
the error.


Incorrect (note space in filename, and double "Mailing
efu...@li......"):

cvs commit -m "clarity rewording" "character-writer's
reference.txt" (in directory C:\Programs\EFUM\)
Checking in character-writer's reference.txt;
/cvsroot/efum/efum/character-writer's reference.txt,v 
<--  character-writer's reference.txt
new revision: 1.2; previous revision: 1.1
done
Mailing efu...@li......
Generating notification message...
Generating notification message... done.
Mailing efu...@li......
Generating notification message...
Traceback (most recent call last):
  File "/cvsroot/sitedocs/CVSROOT/cvstools/syncmail",
line 433, in ?
    main()
  File "/cvsroot/sitedocs/CVSROOT/cvstools/syncmail",
line 426, in main
    contextlines, fromhost, replyto)
  File "/cvsroot/sitedocs/CVSROOT/cvstools/syncmail",
line 252, in blast_mail
    print >> s, calculate_diff(entry, contextlines)
  File "/cvsroot/sitedocs/CVSROOT/cvstools/syncmail",
line 147, in calculate_diff
    filestr = filestr.replace('\', '\')
UnboundLocalError: local variable 'filestr' referenced
before assignment

Correct (no space in filename):

cvs commit -m "recent engine changes require a revision
bump" Project1.vbp (in directory C:\Programs\EFUM\)
Checking in Project1.vbp;
/cvsroot/efum/efum/Project1.vbp,v  <--  Project1.vbp
new revision: 1.13; previous revision: 1.12
done
Mailing efu...@li......
Generating notification message...
Generating notification message... done.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450019&aid=998320&group_id=47611

[Cvs-syncmail] [ cvs-syncmail-Bugs-989471 ] be able to parse new info format string

[SourceForge.net <no...@so...>]

Bugs item #989471, was opened at 2004-07-12 14:50
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450019&aid=989471&group_id=47611

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Patrick Ruckstuhl (butcherch)
Assigned to: Nobody/Anonymous (nobody)
Summary: be able to parse new info format string

Initial Comment:
The info format string changed in newer cvs versions. 

See also
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=102292

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450019&aid=989471&group_id=47611

[Cvs-syncmail] Using Authenticated SMTP server to send (ESMTP)

[Zhenlei C. <li...@ga...>]

I managed to ues smtplib's login feature to make syncmail work with my 
authenticated SMTP server.
I am not sure if this feature is already in latest version of syncmail 
(I was using  1.2+cvs.2004.0 as in  Debian).
If not I can provide a patch.

[Cvs-syncmail] [ cvs-syncmail-Bugs-967653 ] ImportError: cannot import name formataddr

[SourceForge.net <no...@so...>]

Bugs item #967653, was opened at 2004-06-06 12:02
Message generated for change (Comment added) made by mokhov
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450019&aid=967653&group_id=47611

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Serguei A. Mokhov (mokhov)
Assigned to: Nobody/Anonymous (nobody)
Summary: ImportError: cannot import name formataddr

Initial Comment:
Hello,

I have Python 2.2 installed. After upgrading to
syncmail 2.1 I started getting the below. Looks like it
cannot find 'formataddr' for some reason. Any insight
on the matter would be appreciated.

Checking in wrappers/Worker.java;
/cvsroot/gipsy/gipsy/src/gipsy/wrappers/Worker.java,v 
<--  Worker.java
new revision: 1.9; previous revision: 1.8
done
Traceback (most recent call last):
  File "/cvsroot/gipsy/CVSROOT/syncmail", line 103, in ?
    from email.Utils import formataddr
ImportError: cannot import name formataddr

-s


----------------------------------------------------------------------

>Comment By: Serguei A. Mokhov (mokhov)
Date: 2004-06-07 09:00

Message:
Logged In: YES 
user_id=560391

That's what I suspected -- 2.2 is not enough, but was
misguided by the comment in the syncmail file:

# NOTE: SourceForge currently runs Python 2.2.3, so we need
to remain
# compatible with the Python 2.2 line.

This ought to change to "with the Python 2.2.2 line."

Thanks!

-s


----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2004-06-07 05:49

Message:
Logged In: NO 

formataddr was added to python v2.2.2 - syncmail will fail on 
any version before that. Sounds like you need to upgrade 
your python...

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450019&aid=967653&group_id=47611

[Cvs-syncmail] [ cvs-syncmail-Bugs-967653 ] ImportError: cannot import name formataddr

[SourceForge.net <no...@so...>]

Bugs item #967653, was opened at 2004-06-06 09:02
Message generated for change (Comment added) made by nobody
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450019&aid=967653&group_id=47611

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Serguei A. Mokhov (mokhov)
Assigned to: Nobody/Anonymous (nobody)
Summary: ImportError: cannot import name formataddr

Initial Comment:
Hello,

I have Python 2.2 installed. After upgrading to
syncmail 2.1 I started getting the below. Looks like it
cannot find 'formataddr' for some reason. Any insight
on the matter would be appreciated.

Checking in wrappers/Worker.java;
/cvsroot/gipsy/gipsy/src/gipsy/wrappers/Worker.java,v 
<--  Worker.java
new revision: 1.9; previous revision: 1.8
done
Traceback (most recent call last):
  File "/cvsroot/gipsy/CVSROOT/syncmail", line 103, in ?
    from email.Utils import formataddr
ImportError: cannot import name formataddr

-s


----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2004-06-07 02:49

Message:
Logged In: NO 

formataddr was added to python v2.2.2 - syncmail will fail on 
any version before that. Sounds like you need to upgrade 
your python...

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450019&aid=967653&group_id=47611

[Cvs-syncmail] [ cvs-syncmail-Bugs-967653 ] ImportError: cannot import name formataddr

[SourceForge.net <no...@so...>]

Bugs item #967653, was opened at 2004-06-06 12:02
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450019&aid=967653&group_id=47611

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Serguei A. Mokhov (mokhov)
Assigned to: Nobody/Anonymous (nobody)
Summary: ImportError: cannot import name formataddr

Initial Comment:
Hello,

I have Python 2.2 installed. After upgrading to
syncmail 2.1 I started getting the below. Looks like it
cannot find 'formataddr' for some reason. Any insight
on the matter would be appreciated.

Checking in wrappers/Worker.java;
/cvsroot/gipsy/gipsy/src/gipsy/wrappers/Worker.java,v 
<--  Worker.java
new revision: 1.9; previous revision: 1.8
done
Traceback (most recent call last):
  File "/cvsroot/gipsy/CVSROOT/syncmail", line 103, in ?
    from email.Utils import formataddr
ImportError: cannot import name formataddr

-s


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450019&aid=967653&group_id=47611

[Cvs-syncmail] [ cvs-syncmail-Patches-608144 ] truncate long reports

[SourceForge.net <no...@so...>]

Patches item #608144, was opened at 2002-09-12 04:02
Message generated for change (Comment added) made by davidfraser
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450021&aid=608144&group_id=47611

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Norman Vine (nhv)
Assigned to: Nobody/Anonymous (nobody)
Summary: truncate long reports

Initial Comment:
syncmail currently truncates long reports from any 
individual file but can still spew long reports if many 
files are committed at once.  This simple patch adds 
a total lines counter that will truncate the total 
message length.  I arbritrarily used the same length 
to truncate at as was used for an individual file, this 
can easily be changed.  All files changed will still be 
reported but the details will be omitted for all files 
after the chosen truncation length.  This code is 
untested

----------------------------------------------------------------------

Comment By: David Fraser (davidfraser)
Date: 2004-06-03 09:47

Message:
Logged In: YES 
user_id=221678

This would be a great help to mailing list administrators
who currently have to deal with removing all excess size
mails...

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450021&aid=608144&group_id=47611

[Cvs-syncmail] [ cvs-syncmail-Patches-961999 ] do not include gecos comments in from field

[SourceForge.net <no...@so...>]

Patches item #961999, was opened at 2004-05-27 21:13
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450021&aid=961999&group_id=47611

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: do not include gecos comments in from field

Initial Comment:
syncmail uses entries in /etc/passwd to find the full name to be 
included in From: field of the mail. 

However, entries in /etc/passwd can also be used to store 
comments, phone, etc (gecos syntax) and syncmail should not 
include these.

Simple patch included.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450021&aid=961999&group_id=47611

[Cvs-syncmail] [ cvs-syncmail-Patches-938197 ] Use CVS_USER if available

[SourceForge.net <no...@so...>]

Patches item #938197, was opened at 2004-04-19 16:43
Message generated for change (Comment added) made by mtraum
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450021&aid=938197&group_id=47611

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Skip Montanaro (montanaro)
Assigned to: Fred L. Drake, Jr. (fdrake)
Summary: Use CVS_USER if available

Initial Comment:
Here's a simple patch Fred requested which uses the
CVS_USER environment variable as the sender of the
mail in preference to the currently running user.


----------------------------------------------------------------------

Comment By: Mike Traum (mtraum)
Date: 2004-05-06 12:02

Message:
Logged In: YES 
user_id=407536

This patch causes synvmail to fail to send an email if the
cvs user is not a system user.

----------------------------------------------------------------------

Comment By: Skip Montanaro (montanaro)
Date: 2004-04-20 17:26

Message:
Logged In: YES 
user_id=44345

Of course I hosed the diff...  second try.


----------------------------------------------------------------------

Comment By: Skip Montanaro (montanaro)
Date: 2004-04-20 17:22

Message:
Logged In: YES 
user_id=44345

Better patch -  corrects pwinfo based upon CVS_USER


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450021&aid=938197&group_id=47611

[Cvs-syncmail] Re: Bug#247281: Typo in syncmail(1)

[Kevin R. <ke...@ro...>]

There's a minor typo in syncmail.sgml as reported by a Debian user:

Martin Schulze wrote:
> Package: cvs-syncmail
> Version: 1.2+cvs.2004.05.02-1
> Severity: minor
> Tags: patch
> 
> -  cally shorted than context diffs, but many users find it easier  to  read
> +  cally shorter than context diffs, but many users find it easier  to  read
>                ^
> 
> Please forward upstream.
> 
> Regards,
> 
> 	Joey
> 
-- 
Kevin Rosenberg
ke...@ro...

[Cvs-syncmail] [ cvs-syncmail-Patches-938197 ] Use CVS_USER if available

[SourceForge.net <no...@so...>]

Patches item #938197, was opened at 2004-04-19 16:43
Message generated for change (Settings changed) made by montanaro
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450021&aid=938197&group_id=47611

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Skip Montanaro (montanaro)
>Assigned to: Fred L. Drake, Jr. (fdrake)
Summary: Use CVS_USER if available

Initial Comment:
Here's a simple patch Fred requested which uses the
CVS_USER environment variable as the sender of the
mail in preference to the currently running user.


----------------------------------------------------------------------

Comment By: Skip Montanaro (montanaro)
Date: 2004-04-20 17:26

Message:
Logged In: YES 
user_id=44345

Of course I hosed the diff...  second try.


----------------------------------------------------------------------

Comment By: Skip Montanaro (montanaro)
Date: 2004-04-20 17:22

Message:
Logged In: YES 
user_id=44345

Better patch -  corrects pwinfo based upon CVS_USER


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=450021&aid=938197&group_id=47611