#24 syncmail fails when filenames have apostrophies
Committing filenames with spaces appears to cause
syncmail problems... as shown below. I've tried this
with a number of files for the same project, those with
spaces in the filenames are the only ones that trigger
the error.
Incorrect (note space in filename, and double "Mailing
efum-commit@lists.sourceforge.net..."):
cvs commit -m "clarity rewording" "character-writer's
reference.txt" (in directory C:\Programs\EFUM\)
Checking in character-writer's reference.txt;
/cvsroot/efum/efum/character-writer's reference.txt,v
<-- character-writer's reference.txt
new revision: 1.2; previous revision: 1.1
done
Mailing efum-commit@lists.sourceforge.net...
Generating notification message...
Generating notification message... done.
Mailing efum-commit@lists.sourceforge.net...
Generating notification message...
Traceback (most recent call last):
File "/cvsroot/sitedocs/CVSROOT/cvstools/syncmail",
line 433, in ?
main()
File "/cvsroot/sitedocs/CVSROOT/cvstools/syncmail",
line 426, in main
contextlines, fromhost, replyto)
File "/cvsroot/sitedocs/CVSROOT/cvstools/syncmail",
line 252, in blast_mail
print >> s, calculate_diff(entry, contextlines)
File "/cvsroot/sitedocs/CVSROOT/cvstools/syncmail",
line 147, in calculate_diff
filestr = filestr.replace('\', '\\')
UnboundLocalError: local variable 'filestr' referenced
before assignment
Correct (no space in filename):
cvs commit -m "recent engine changes require a revision
bump" Project1.vbp (in directory C:\Programs\EFUM\)
Checking in Project1.vbp;
/cvsroot/efum/efum/Project1.vbp,v <-- Project1.vbp
new revision: 1.13; previous revision: 1.12
done
Mailing efum-commit@lists.sourceforge.net...
Generating notification message...
Generating notification message... done.
Logged In: YES
user_id=553378
All of my files with spaces in the filename also had
apostrophies ('); just committed one with spaces but no
apostrophies and had no problems, so I'm assuming the
apostrophies are responsible.