Re: gnu m4

[Alexey M. <al...@hs...>]

>>>>> "AD" == Alberto Dainotti <al...@ur...> writes:

 AD> Hello, I'm doing some work to make cvs-nserver full OpenBSD compliant
 AD> :-)

It's nice to hear! 

 AD> Basically there are three things to do to successfully build
 AD> cvs-nserver on OpenBSD:

 AD> 1) Cut out the line below from src/server.c : #define _POSIX_SOURCE 1

Ok, this whole idea with _*_SOURCE was not that brilliant.  Removed. 

 AD> (server.c includes <sys/socket.h> which has some non posix
 AD> declarations, and also uses FD_SETSIZE which is declared in
 AD> sys/types.h only when _POSIX_SOURCE is not declared)

Actually, I think that eventually those headers and the appropriate code
would be removed from cvs-nserver altogether, and moved to one of the
*-client.c (hopefully more cleanly).

Also, I don't think that FD_SETSIZE usage is that critical.  I think it
could be removed too (select() will return appropriate error, if this
number is too high for it).

But that's orthogonal to a current question. 



 AD> 2) Install gnu-m4 which is not supported by OpenBSD (gnu m4 is not
 AD> even present in to the ports tree of release 3.0).  It seems that
 AD> OpenBSD's m4 can substitute gnu m4 in almost every situation , but the
 AD> following autoconf rule which checks for gnu m4 fails:

 AD> AC_PROG_GNU_M4

 AD> (it fails checking for frozen files support)

I believe that this should be directed towards Autoconf guys.  Could you
please write a message to aut...@gn... with the description of failure?
We'll catch up when the corresponding Autoconf release will be out. 


 AD> 3) Compile with GNU Make.

I believe that *BSD people are already used to type 'gmake' right after
'./configure' :) 


 AD> Now, point (1) is a suggestion to patch source code.  Point (3) is no
 AD> problem. About point (2) is not clear to me if the AC_PROG_GNU_M4 rule
 AD> was inserted in configure.in by some automatic tool like autoscan or
 AD> was manually inserted by cvs-nserver coders , and why it was inserted.
 AD> Do you think it is strictly needed ?

I think that it is needed for the Autotest stuff.  I've looked at the
M4-related stuff in configure.in, and I think I'll try to remove it and see
if it's still works.  I think that's remnants from the days of Autoconf
2.52 betas.


 AD> Also in the next days I hope to send you patches to integrate OpenBSD
 AD> changes made to cvs into cvs-nserver.  Actually I have made a single
 AD> patch yet and I tested it. But I want to separate it in single patches
 AD> for each bugfix/feature made by the OpenBSD team, before submitting
 AD> them to you.

Wonderful!  Btw, why don't you simply submit those patches to a stock CVS?
That way we'll catch them up automatically on next CVS release.  Although,
sure, if you think that those patches are needed for nserver -- I agree.


Thanks, 

--alexm