Re: cvsgroup bug

[Alexey M. <al...@hs...>]

>>>>> "AM" == Alexey Morozov <mo...@no...> writes:

 AM> It seems that currently cvsgroup file can't contain empty groups, I
 AM> got smth like

 AM> E Error reading the cvsgroup file, line 3

 AM> line 3 is %smscmgmt_readers: <cr>

Humm, never thought of that :) Fixed.  It was even considered a special
case of brokenness. :)

 AM> BTW, Alex, do you plan to implement 'cvs group' command as stated in
 AM> acl-cli.txt? I think it's an important task, really... For now I just
 AM> perform a perl workarounds (well, the works in progress) including cvs
 AM> co CVSROOT, edit CVSROOT/cvsgroup and check things in back to
 AM> repository. This may be the way (especially when we talk about core
 AM> simplicity) but the we should cleanly state this in our docs. 

I'm in favor for doing this that way.  I think that dull string
manipulations are really the client issue.

Maybe you're going to change a little the procedure of modifying user
groups?  I.e., in the web-interface there's going to be "start editing the
cvsgroups file", "add/remove group/user to group", "commit the cvsgroups
file"?   With an optional window of directly-editing that checked out
cvsgroup using <textarea>?

I think that's really going to be much better.  Otherwise, we'll have the
temptation of adding all kinds of various text file manipulations to a
server, the need to bother with locking, etc....  I hate this.

 AM> But this seems to be a security issue...

Huh?  Where is the security issue?

--alexm