#1422 MSVC warnings in 7.38.0 SSPI Unicode build

closed-fixed
None
5
2014-09-26
2014-09-10
Marcel Raad
No

When Unicode is enabled, Microsoft Visual C++ 2013 complains about 'wchar_t ' and 'char ' being incompatible in Curl_sasl_build_spn and Curl_sasl_create_gssapi_security_message:
curl_sasl_sspi.c(88): warning C4133: '!=' : incompatible types - from 'TCHAR ' to 'char '
curl_sasl_sspi.c(581): warning C4133: 'function' : incompatible types - from 'SEC_WCHAR ' to 'const char '
curl_sasl_sspi.c(596): warning C4133: 'function' : incompatible types - from 'SEC_WCHAR ' to 'const char '

The attached patch fixes those warnings. Perhaps someone could verify that the Curl_sasl_create_gssapi_security_message part does now what it should do when Unicode is enabled - this function is currently only used in the e-mail protocol functions and I build libcurl with HTTP_ONLY.

1 Attachments

Discussion

  • Steve Holme

    Steve Holme - 2014-09-10
    • status: open --> open-confirmed
    • assigned_to: Steve Holme
     
  • Steve Holme

    Steve Holme - 2014-09-10

    Cheers Marcel,

    It's a known issue that I was hoping to resolve before the release but unfortunately I ran out of time. You will note there is a TODO on line 489 so I don't forget about it.

    All being well I'll take a look at this over the next couple of days.

    Thanks again for the patch and the gentle reminder ;-)

    Kind Regards

    Steve

     
  • Steve Holme

    Steve Holme - 2014-09-13

    I have now verified the Unicode build of the new GSSAPI code in curl_sasl_sspi.c and pushed a modified version of your patch as commit bd3df5ec6d.

    Many thanks for your assistance on this.

    Kind Regards

    Steve

     
  • Steve Holme

    Steve Holme - 2014-09-13
    • status: open-confirmed --> closed-fixed
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks