#1316 Regarding NTLMv2 Authentication support in CURL

[Dushyant chaudhary]

Hi Alias,

I have asked this question before, about the NTLMv2 support in CURL,but Daniel Mentioned there is no support for it.
Refer below link:
http://curl.haxx.se/mail/archive-2013-10/0006.html

So we have written NTLMv2 authentication algorithm in Curl code using the following link.
http://davenport.sourceforge.net/ntlm.html

Also we are done with some basic testing of the code and it seems working fine over NTLMv2 authentication.

I have few queries here :

1)Would somebody from the CURL team be available for code review if I share the code changes.

2)We want to publish this code and get this in official release of CURL. What is the procedure to do so.

3)How much time will it take to provide us the official release so that we can integrate libcurl in our code.

Any inputs will be highly appreciated.

Thanks and Regards
Dushyant

[Steve Holme]

Hopefully I can answer your queries:

1) A number of us have some NTLM experience so I'm sure we can assist you in reviewing and integrating your changes into the repository. For example I reworked the HTTP NTLM support so that it could be used by the email protocols. I also plan to extend the NTLM WinBind support so that it can be used by the email protocols (SASL module) as well.

2) Please take a look at the following link but in summary post your changes as git patch files to the libcurl mailing list and try and break your changes up into smaller more manageable commits rather than one huge commit which will assist problem finding but reviewing of the commits:

http://curl.haxx.se/dev/contribute.html

The benefit of using the mailing list rather than the bug reporting system is that more people will see your posts and there will be the opportunity for greater input and feedback.

3) That all depends on how complicated your changes are, how closely your changes match our coding standards, whether they break any existing tests, what new test cases are needed, whether any documentation needs updating (user and API wise) and how quickly you can turn around reworking of patches (if need be) after feedback. Until we see the changes I don't think we could provide a timescale but to give you some idea of our release schedule:

v7.34.0 was released recently so we have approximately a month to integrated new features and then another month of testing and bug fixes before the next release.

[Daniel Stenberg]

A formality perhaps, but still true: this is not a bug. Please take everything that isn't plain bug reports to the curl-library list for discussion, review, debate and more. I therefore mark this as pending-invalid now and will close soonish unless motivated why not.

Regarding the time schedule, we do releases every 2 months so your change could be included in any of the releases as soon as its been reviewed and merged into the code. So it'll depend on how fast the progress goess!

[Daniel Stenberg]

Closing this entry now. Please take the discussion, patches and coming reviews to the curl-library mailing list.