please apply hiphop patch

curl is at curl.haxx.se

This project can now be found here.

#1036 please apply hiphop patch

Status: closed-invalid

Owner: Daniel Stenberg

Labels: libcurl (356)

Priority: 5

Updated: 2013-06-21

Created: 2011-08-18

Creator: Mark A. Hershberger

Private: No

Here it is: https://raw.github.com/facebook/hiphop-php/master/src/third_party/libcurl.fb-changes.diff Also attached.

Discussion

Mark A. Hershberger - 2011-08-18

The patch

libcurl.fb-changes.diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Daniel Stenberg - 2011-08-19

Thanks,

If FD_SETSIZE is a problem you're using a very large amount of file descriptors. If you're using a large amount of file descriptors then poll() is also very slow and a bad choice. Hence libcurl provides the multi_socket API to allow the app to work around both the FD_SETSIZE problem as well as completely avoiding slow functions such as poll() and select().

I'm not seeing the major benefit of this function.

If you still think this is good stuff for libcurl, then I would like to see that you motivate and explain your patch and reasoning on the curl-library list so that we can discuss pros and cons and see what others think and how to proceed. (The patch also lacks documentation and test cases.)

This is not a bug, so this bug entry will be closed.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Daniel Stenberg - 2011-08-19

status: open --> pending-invalid
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Daniel Stenberg - 2011-09-06

status: pending-invalid --> closed-invalid
If you would like to refer to this comment somewhere else in this project, copy and paste the following link: