Re: Removing bundled libs in curl-loader

[Robert I. <cor...@gm...>]

Yes, you are right.

The case for CURLINFO_ERROR: to be removed.

Unless the old API of libcurl, libevent and cares is broken,
this is the only source change required.

Thanks,
Regards,
Robert


On Tue, Sep 22, 2015 at 1:09 PM, Pavel Alexeev <fo...@hu...> wrote:
> Hi Robert.
>
> Honestly I do not understand you. If there no sources changed, how it
> became build able without patches?
> I have tried and got same error as was report initially:
>
> $ LANG=C make
> gcc -W -Wall -Wpointer-arith -pipe -DCURL_LOADER_FD_SETSIZE=20000
> -D_FILE_OFFSET_BITS=64  -O3 -ffast-math -finline-functions
> -funroll-all-loops -finline-limit=1000 -mmmx -msse
> -foptimize-sibling-calls -g -I. -I./inc -I/usr//include -c -o
> obj/loader.o loader.c
> loader.c: In function 'client_tracing_function':
> loader.c:1262:10: error: 'CURLINFO_ERROR' undeclared (first use in this
> function)
>      case CURLINFO_ERROR:
>           ^
> loader.c:1262:10: note: each undeclared identifier is reported only once
> for each function it appears in
> Makefile:109: recipe for target 'obj/loader.o' failed
> make: *** [obj/loader.o] Error 1
>
> CURLINFO_ERROR indeed introduced in your curl-trace-info-error.patch
> patch, and that symbol does not found in system curl present in Fedora
> for example.
>
> On 21.09.2015 19:59, Robert Iakobashvili wrote:
>> Hi Pavel,
>> I've cutted libcurl, libevent and libcares custom building:
>> see the Makefile attached (I've not tried it, sorry)
>> to be used instead of the one in curl-loader-0.56.
>>
>> My guess, you will create a patch.
>>
>> Thank you.
>> Regards,
>> Robert
>>
>>
>> On Mon, Sep 21, 2015 at 7:38 PM, Robert Iakobashvili
>> <cor...@gm...> wrote:
>>> Hi Pavel,
>>> From curl-loader-0.56
>>>
>>> Just patch the Makefile file
>>> as described below not to build custom libcurl and libevent
>>> and instead push there standard libraries from your distribution.
>>>
>>>
>>> Regards,
>>> Robert
>>>
>>>
>>> On Mon, Sep 21, 2015 at 6:56 PM, Pavel Alexeev <fo...@hu...> wrote:
>>>> From what tarball I could build that?
>>>>
>>>> On 20.09.2015 23:17, Robert Iakobashvili wrote:
>>>>> Hi Pavel,
>>>>>
>>>>> In curl-loader Makefile:
>>>>>
>>>>> 1. comment our targets libcurl and libevent from build;
>>>>>
>>>>> 2. provide instead standard paths/locations of these libraries
>>>>>     that in any case are specific for your distribution.
>>>>>
>>>>> Kind regards,
>>>>> Robert
>>>>>
>>>>>
>>>>> On Sun, Sep 20, 2015 at 10:47 PM, Pavel Alexeev <fo...@hu...> wrote:
>>>>>> Thank you very much!
>>>>>>
>>>>>> But version still 0.56 for download. Could you please release new version?
>>>>>>
>>>>>> Or it intended to be built from source system?
>>>>>>
>>>>>> Should I use some switches to do not use patches, or just delete them is
>>>>>> enough?
>>>>>>
>>>>>> On 04.08.2015 16:33, Robert Iakobashvili wrote:
>>>>>>> Dear Pavel,
>>>>>>>
>>>>>>> This is to confirm that curl-loader will work properly without patches
>>>>>>> for libcurl and libevent.
>>>>>>>
>>>>>>> The patches have their own advantages but not so important.
>>>>>>>
>>>>>>> I do not have any clues about fsf addresses, though.
>>>>>>> Regards,
>>>>>>> Robert
>>>>>>>
>>>>>>>
>>>>>>> On Sat, Jul 25, 2015 at 1:49 PM, Pavel Alexeev <fo...@hu...> wrote:
>>>>>>>> Hello Robert.
>>>>>>>> Firstly I glad receive response from you.  Thanks. I also had write
>>>>>>>> about incorrect fsf address in files headers which leaved without answer
>>>>>>>> (it is not stop issue, but I should be inform you [1]), and also there
>>>>>>>> long time no new curl-loader releases... So I became fear project abandoned.
>>>>>>>>
>>>>>>>> What concerned libevent patch, had it been ever proposed to include for
>>>>>>>> upstream libevent project? Is it possible to do?
>>>>>>>>
>>>>>>>> [1]
>>>>>>>> https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
>>>>>>>>
>>>>>>>> On 24.07.2015 12:43, Robert Iakobashvili wrote:
>>>>>>>>> Dear Pavel,
>>>>>>>>> First, we like truly community distros like
>>>>>>>>> Debian and Fedora.
>>>>>>>>>
>>>>>>>>> Originally, we had 4-5 patches for libcurl, mainly increasing productivity,
>>>>>>>>> and all were integrated to libcurl besides this
>>>>>>>>> one that Daniel, the curl maintainer, had hesitated to incorporate.
>>>>>>>>>
>>>>>>>>> I will look next week into this matter and what could be done,
>>>>>>>>> but we have a good command of libcurl and error codes
>>>>>>>>> were not a substituted from my mems.
>>>>>>>>>
>>>>>>>>> There's a one more essential patch and it's for libevent library.
>>>>>>>>> This patch increases in some define maximum number of allowed
>>>>>>>>> file descriptors to enable much higher productivity for curl-loader.
>>>>>>>>>
>>>>>>>>> Without this libevent patch curl-loader will function with a limit
>>>>>>>>> of the number of connection specified in libevent as low as only 64K
>>>>>>>>> as I remember, but it will function properly within this limitation.
>>>>>>>>>
>>>>>>>>> Regards,
>>>>>>>>> Robert
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Fri, Jul 24, 2015 at 12:16 PM, Pavel Alexeev <fo...@hu...> wrote:
>>>>>>>>>> Hello.
>>>>>>>>>>
>>>>>>>>>> I'm Pavel. I have intension include curl-loader into Fedora Linux
>>>>>>>>>> distribution.
>>>>>>>>>> Unfortunately you use bundled copies of curl, c-ares and some other in
>>>>>>>>>> packages directory.
>>>>>>>>>>
>>>>>>>>>> That is strongly prohibited by our rules:
>>>>>>>>>> https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries
>>>>>>>>>>
>>>>>>>>>> I have tried link curl-loader with system libraries, and observe you
>>>>>>>>>> patch that software (patches directory).
>>>>>>>>>> Brief look at curl-trace-info-error.patch leave me in frustration. Why
>>>>>>>>>> you prefer patch that library instead of use wide range of predefined
>>>>>>>>>> error codes http://curl.haxx.se/libcurl/c/libcurl-errors.html ?
>>>>>>>>>>
>>>>>>>>>> So, in that point it is stop issue.
>>>>>>>>>> Do you willing working on that issue?
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> With best wishes, Pavel Alexeev (aka Pahan-Hubbitus). For fast contact
>>>>>>>>>> with me you would use jabber: Pa...@Hu...
>>>>>>>>>>
>>>>>>>>>> ------------------------------------------------------------------------------
>>>>>>>>>> _______________________________________________
>>>>>>>>>> curl-loader-devel mailing list
>>>>>>>>>> cur...@li...
>>>>>>>>>> https://lists.sourceforge.net/lists/listinfo/curl-loader-devel
>