Re: building urls from server responses

[Gary F. <ga...@in...>]

We've had a major crunch at work for the last week,
but I'll try to get this done soon,
hopefully this weekend.


On Nov 27, 2008, at 2:41 PM, Robert Iakobashvili wrote:

> Hi Gary,
>
> Had you a chance to look at the below changes?
> We would like to add the new tags also to the man and web-pages and to
> make a new release.
>
> Thanks,
> Robert
>
>
>
> ==========================================================
> - explaining to potential users how to use the new tags.
> Please, look at README changes and review them:
> http://curl-loader.svn.sourceforge.net/viewvc/curl-loader/trunk/curl-loader/doc/README?r1=534&r2=546
>
> Added example files:
>
> http://curl-loader.svn.sourceforge.net/viewvc/curl-loader/trunk/curl-loader/conf-examples/url-template-fr-file.conf?revision=546&view=markup
> http://curl-loader.svn.sourceforge.net/viewvc/curl-loader/trunk/curl-loader/conf-examples/url-template-resp-dynamic.conf?view=markup
> http://curl-loader.svn.sourceforge.net/viewvc/curl-loader/trunk/curl-loader/conf-examples/url-template-file.txt?revision=546&view=markup
>
> Afterwards, the man-pages and the web-site pages to be updates
>
> - code reviewing and potential bugs tracking.
>
> In meanwhile, I have detected only a single potential issue:
> in load_fsm.c
>
> Calling of newly added close_connections() with a curl_easy_cleanup ()
> for a client CURL handle is a bugfix for clients in  
> CSTATE_FINISHED_OK state.
> However, it make create a bug for clients in state CSTATE_ERROR.
>
> Such clients with an error in one cycle may be re-scheduled once more
> for another cycle, thus, they will be attempted to be added to the  
> multi-handle,
> rejected as null, and, therefore, such clients will be never  
> scheduled again for
> more loading cycles (there is a command-line option to configure for
> such behavior,
> which is not the default).
>
> Calling curl_easy_cleanup () is a good hint to libcurl multi-handle to
> decrease the pool of connections to the server. Added for clients in
> error-state one more curl_easy_init() as you can see in svn.
>
> - bringing the newly added code to the coding conventions
>  and coding style of the project (I started that, note, that a couple
>  functions have been re-named to make their names more clear);
> - removing various extern declarations (done for functions);
> - functions should have function caption with description in  
> appropriate
>  format;
>
>>
>> Since I submitted these changes I've found the need for a couple more
>> tags.
>> I'll send those along in a day or so when I've been able to test  
>> them.
>
> Great!
> If you can work against the code in svn and submit your code as  
> patches
> diff -Naru newcode-tree old-core-tree > somepatch.patch, it may make
> integration easier.
>
> Try, where it is possible to follow the project's coding style and  
> conventions.
> Thanks!
>
> --
> Truly,
> Robert Iakobashvili, Ph.D.
> ......................................................................
> Assistive technology that understands you
> ......................................................................