Re: building urls from server responses

[Gary F. <ga...@in...>]

Everything tests out just fine, Robert.

One question: you put most of the new code (that was in a separate  
file url_set.c)
into parse_conf.c. A lot of that is "run time" code that is executed  
while the load
is running, while parse_conf.c used to contain only parse-time code.  
Is that OK?
Or do you want to put run-time code into loader.c or a separate file?  
Either is
fine -- depends on how you want to organize it.

Since I submitted these changes I've found the need for a couple more  
tags.
I'll send those along in a day or so when I've been able to test them.


On Nov 20, 2008, at 9:11 AM, Robert Iakobashvili wrote:

> Thank you for your great contribution to the project.
> I liked your design decisions.
> Confident, that many people will enjoy the features, that you  
> developed.
>
> It was integrated to the existing files deliberately without serious  
> changes.
> Could you, please, checkout from svn the latest version and run
> as much tests in your conditions to see, that nothing was broken  
> upon integration?
> Thank you in advance.
>
> We will still need to polish the code, bring coding conventions and  
> comments,
>  README, FAQs and man pages. Later I will submit my suggestions.
>
> Once more, thank you and my appreciations for the good job!