Re: building urls from server responses

[Robert I. <cor...@gm...>]

Hi Gary,

On Wed, Nov 12, 2008 at 11:51 PM, Gary Fitts <Ga...@in...> wrote:

> Oops, I forgot to include one file..
>
>
>
> Hello Robert,
>
> Here are the additions to curl-loader that I've been working on. The new
> tags are documented in an attached file. They allow clients to fetch urls
> built from prior server responses, or from a token file.
>
> There are also a few bug fixes (at least I think they were bugs): multiple
> clients can now upload the same file repeatedly without interference,
> form_strings can now have many %s markers, and whitespace is removed from
> form_string tokens. (The code always removed whitespace, but a minor bug
> caused the original token to be used instead.)
>
> I tried to keep all of my changes in one new source file, url_set.c, but I
> had to put hooks and small changes into 5 other files: url.h, client.h,
> parse_conf.c, loader.c, and loader_fsm.c. These are all included. I've
> marked all the changes with GF in a comment to make them easy to find.
>
> I've tested all this to my own satisfaction, but of course there will be
> bugs that I haven't uncovered yet.
>
> If you want to adopt any of these changes, it might make sense to move the
> url_set.c code back into parse_conf.c and loader.c -- whatever is most
> convenient.
>
> Gary Fitts
>

Thank you for your great contribution to the project.
I liked your design decisions.
Confident, that many people will enjoy the features, that you developed.

It was integrated to the existing files deliberately without serious
changes.
Could you, please, checkout from svn the latest version and run
as much tests in your conditions to see, that nothing was broken upon
integration?
Thank you in advance.

We will still need to polish the code, bring coding conventions and
comments,
 README, FAQs and man pages. Later I will submit my suggestions.

Once more, thank you and my appreciations for the good job!

Sincerely,
Robert Iakobashvili, Ph.D.
......................................................................
www.ghotit.com
Assistive technology that understands you
......................................................................