#67 A failed test reports as success

[Adrian Tineo]

In run_single_test() at Framework/TestRun.c a failed test is not setting the result variable to a suitable state, thus returning with the initialized default value of CUE_SUCCESS. At line 1011:

  if (pRunSummary->nFailureRecords > nStartFailures) {
    pRunSummary->nTestsFailed++;
    if (NULL != pLastFailure) {
      pLastFailure = pLastFailure->pNext;  /* was a previous failure, so go to next one */
    }
    else {
      pLastFailure = f_failure_list;       /* no previous failure - go to 1st one */
    }
  }
  else {
    pLastFailure = NULL;                   /* no additional failure - set to NULL */
  }

This block should set the result var to a meaningful error code other than default CUE_SUCCESS, e.g. CUF_AssertFailed.

[Adrian Tineo]

The if block above should update the result var.