#9 Avoid function pointer casts

closed-accepted
nobody
None
5
2006-03-20
2006-03-18
No

With the attached patch, the function pointer casts for
the PySequenceMethods structures become unnessary. As a
consequence, the #defines to provide backwards
compatibility with versions before 2.5 also become
unnecessary.

Discussion

  • Martin v. Löwis

     
  • Thomas Heller

    Thomas Heller - 2006-03-20

    Logged In: YES
    user_id=11105

    At least these defines must be kept, otherwise the sources
    cannot be compiled with Python 2.4:

    #define readbufferproc getreadbufferproc

    #define writebufferproc getwritebufferproc

    #define segcountproc getsegcountproc

    #define charbufferproc getcharbufferproc

     
  • Martin v. Löwis

    Logged In: YES
    user_id=21627

    Ah, I forgot them. Please review the revised patch.

     
  • Martin v. Löwis

     
  • Thomas Heller

    Thomas Heller - 2006-03-20
    • status: open --> closed-accepted
     
  • Thomas Heller

    Thomas Heller - 2006-03-20

    Logged In: YES
    user_id=11105

    I've applied the patch. Thanks.
    The source code looks indeed nicer now.

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks