Re: [Ctool-develop] little fixes

[Shaun F. <fli...@so...>]

Steven,

I've committed your insertBefore() method to CVS.

As for your comment about vectors, cTool was originally written in C=20
(as the poorly named "CTree", which I now know is also a database=20
product).  With version 2.0, I changed over to C++ so a class hierarchy=20=

could be used to clean up the resulting AST - I was not looking to=20
rewrite from scratch using C++.

Thanks,
Shaun

On Thursday, July 31, 2003, at 11:29  AM, Steven Singer wrote:

> Stefan Seefeld wrote:
>> +++ src/decl.cpp	2003-07-31 11:09:43.000000000 -0400
>> @@ -128,7 +128,7 @@
> [...]
>> -			cout << " ";
>> +			std::cout << " ";
>
> Nope, should be 'out' not 'cout' or 'std::cout' otherwise when you're
> outputting to a file the spaces go to the wrong place.
>
> This bug has been noted before and has been fixed. It's ID 610027.
> Go to the bugs list on SourceForge and select Status: Any instead of
> the default status Open.
>
> I can't comment on your other fixes. I think my version of gcc is so
> old it lets me get away without the std::.
>
> While we're on the subject of patches ... For a project I was writing
> I needed a way of inserting a statement before another given
> statement. The only function I could see for insertion inserted after
> a given statement, so I wrote a function to do what I wanted. I've =
left
> the linked list singly linked so the insertion time is fairly poor, =
but
> it was fine for my implementation.
>
> Anyway, isn't writing your own linked list code a bit pass=E9 =
nowadays,
> shouldn't we be using the STL. (No, I'm not volunteering).
>
> I've attached the patch to this e-mail rather than putting it inline
> as something in my mail system appears to be messing around with
> spaces at the start of lines. This is kind of unfortunate for diffs.
>
> 	- Steven
> --=20
>