Re: [Ctags-devel] Basic.c has compiler errors

[David F. <fis...@ia...>]

 

> -----Original Message-----
> From: en...@cr... [mailto:en...@cr...] On Behalf Of 
> Elliott Hughes
> Sent: Friday, October 06, 2006 12:47 PM
> To: David Fishburn
> Cc: cta...@li...
> Subject: Re: [Ctags-devel] Basic.c has compiler errors
> 
> On 2006-10-06, at 09:06, David Fishburn wrote:
> > So what do we do in this case?
> 
> i've committed a fix. the mistake was that the author of that 
> file was assuming ISO C99 (probably a Unix user), whereas it 
> looks from your output like MSVC insists on ISO C90. i've 
> fixed the other warnings in that file too, and an error in 
> "sql.c" that broke the debug build (presumably on all platforms).

> i think we should have a rule: "no new compiler warnings". 
> i'm assuming Darren has the various -W flags there for a 
> reason. i'll see about fixing the remaining "jscript.c", 
> "python.c", and "sql.c"  
> warnings if they're still broken this weekend.

I maintain both sql.c and jscript.c and when I compile release or build see
no warnings.

What did you have to "fix" in sql.c to correct the warnings?
I am happy to do it, just not sure what it is.

This was your change:
c:\opensrc\ctags_svn>svn diff -r 463 sql.c
Index: sql.c
===================================================================
--- sql.c       (revision 463)
+++ sql.c       (working copy)
@@ -276,6 +276,7 @@

 static void parseBlock (tokenInfo *const token, const boolean local);
 static void makeConstTag (tokenInfo *const token, const sqlKind kind);
+static boolean isCmdTerm (tokenInfo *const token);


And your comment:

trunk/sql.c: fix debug build by adding a missing forward declaration. (My
personal preference would have been to move the static function's definition
to this point in the source, but this isn't my file.) There are still
numerous compiler warnings from this file, but I've no time to look at
anything less serious than build breakage right now.


I am surprised it _was_ compiling for me with the missing forward
declaration.

My C experience is fairly limited and I do not understand your comment
above.  When you get a chance, if you can quickly explain what would be best
I can take care of it.

TIA,
Dave