Menu

#358 Vim parser: Segmentation fault when reaing empty vim file

open
nobody
None
5
2015-05-12
2014-06-20
No

This patch solves the problem.

diff --git a/vim.c b/vim.c
index fb971ea..d1285eb 100644
--- a/vim.c
+++ b/vim.c
@@ -717,6 +717,11 @@ static void findVimTags (void)

        line = readVimLine();

+       if (line == NULL)
+       {
+               return;
+       }
+
        if ( strncmp ((const char*) line, "UseVimball", (size_t) 10) == 0 )
        {
                parseVimBallFile (line);

Discussion

  • Masatake YAMATO

    Masatake YAMATO - 2014-08-01

    Can I merge this patch to https://github.com/fishman/ctags?
    A pull-request to the repository makes me much more happy:)

     
  • Ariya Mizutani

    Ariya Mizutani - 2014-08-01
     
  • David Fishburn

    David Fishburn - 2014-09-19

    I can't for some reason assign this issue to myself, but I have submitted the code to fix this issue in trunk:

    Adding Test\bug358.vim
    Sending vim.c
    Transmitting file data ..
    Committed revision 811.

     
  • Masatake YAMATO

    Masatake YAMATO - 2015-05-12

    David, still you cannot assign the issue to you?

     
  • David Fishburn

    David Fishburn - 2015-05-12

    No, I still cannot assign any issues to myself.

     
  • Masatake YAMATO

    Masatake YAMATO - 2015-05-12

    How do you think tracking the issues at fishman/ctags?
    I slowly tracks the bug tracking system at https://github.com/fishman/ctags/blob/master/docs/tracking.rst.

    In my understanding you are the only person currently active at https://sourceforge.net/p/ctags.
    Though you cannot assign the issue to yourself (and cannot close even if you fixed.). I think it is not health(wrong english?) development.

    If you are o.k. could you tell me your github account?

     

Log in to post a comment.