#348 SQL: SQL Server square brackets quoting isn't supported everywhere

[Colomban Wendling]

The SQL Server square brackets quoting is only supported for tables, not everywhere an identifier is expected.

This breaks the output of the Test/bug1944150.sql test case. With trunk it gives:

cash_trade_comment. Test/bug1944150.sql /^CREATE TRIGGER [tr_d_cash_trade_comment] ON dbo.cash_trade_comment$/;"    T

See that tr_d_cash_trade_comment is completely missing, and that the tag's name is cash_trade_comment. (with the dot). It should actually be:

cash_trade_comment.tr_d_cash_trade_comment  Test/bug1944150.sql /^CREATE TRIGGER [tr_d_cash_trade_comment] ON dbo.cash_trade_comment$/;"    T

---

Attached patch fixes the issue by generalizing support for square brackets quoting. My checks shows no change in test cases output apart for the above.