From: Daniel G. <djg...@gm...> - 2008-11-21 17:39:28
|
Works for me, though I'd prefer we had some feedback from David regarding the initial rationale for this code :-/ On Fri, Nov 21, 2008 at 11:12 AM, Alan Krueger <al...@tr...> wrote: > Waldbaer wrote: > > Well, I did some _changes_, but I did not write the original code. David? > > > If I'm reading the diff correctly, it claims those lines were added in > that revision. > > The problem that I see with this special treatment is that some viewing > > applications may treat a TAB char as 8, some as 4, some as 2 characters > > wide. In fact it's still only one character. > > > > I propose to remove the whole case block for '\t' > I agree. This is really presentation logic embedded in the parser. The > caller can expand the returned column based on how it treats tabs, but > that's not something the parser itself needs to do. > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's > challenge > Build the coolest Linux based applications with Moblin SDK & win great > prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > cssparser-developers mailing list > css...@li... > https://lists.sourceforge.net/lists/listinfo/cssparser-developers > -- Daniel Gredler http://daniel.gredler.net/ |