#21 Cssed icon does not seem to install correctly on gnome 2.6

0.4.0
closed-fixed
Iago Rubio
5
2006-12-27
2005-12-21
No

The cssed icon is installed in share/cssed/pixmaps, whichever gnome
installation is on the machine, which leads to cssed icon not to appear on
the gnome desktop.

Maybe a check is in order here to make it appear (copy into the right
location for gnome)?

Discussion

  • Iago Rubio
    Iago Rubio
    2005-12-22

    • status: open --> pending-accepted
     
  • Iago Rubio
    Iago Rubio
    2005-12-22

    Logged In: YES
    user_id=910507

    It should appear in the menu, as the .desktop file points to
    the icon stored in cssed's data directory, but to make the
    check to install it in the icons directory is ok for me.

    I'll take a look at this, as I think it's a changing target
    lately.

    What's the right icons location on your system ?

    ${prefix}/share/pixmaps

    or

    ${prefix}/share/icons/hicolor/

     
  • Logged In: YES
    user_id=552580

    The problem is the spec is in RedHat only in cvs.

    Not in the tarball. So unless I've missed something it should be added to the
    tarball. And it should work properly.

    Otherwise it seems ok to me. I have not tried to package from cvs at the
    moment, so I cannot say for sure. At the moment, I focus on the 0.4.0 release.

     
    • status: pending-accepted --> open-accepted
     
  • Logged In: YES
    user_id=552580

    You may want to have a look at bluefish configure (though it is horribly
    handled), but it has all the cases with different gtk and gnome versions.

     
  • Iago Rubio
    Iago Rubio
    2005-12-22

    Logged In: YES
    user_id=910507

    > The problem is the spec is in RedHat only in cvs.
    > Not in the tarball. So unless I've missed something it
    > should be added to the
    > tarball.

    You're right.

    I'll take a look into bf's configure.in to catch the grasp
    of it.

     
  • Iago Rubio
    Iago Rubio
    2006-01-23

    Logged In: YES
    user_id=910507

    I've made a quick fix, for this.

    You'll need to update your cssed tree, and pass --with-
    freedesktop-support to configure, to add the desktop icon,
    launcher, and mime info to gnome - and KDE, plus any other
    system following freedesktop.org recommendations.

    There're other changes in the new source tree as the
    interface images, that are compiled now into the executable,
    so the images won't be installed on the system but converted
    at build time.

    Could you please take a try ?

     
  • Logged In: YES
    user_id=552580

    I've tried it.

    Here are the comments:

    1 - I need as all systems which make a package built in a temporary
    directory, then install it in another one a new Makefile flag to disable update
    databases during the compilation.

    2 - I've added various mkinstalldirs which are not in the Makefile, otherwise it
    does not work on a temporary build directory.

    3 - I don't understand well the rebuild-mime-info before installing the
    desktop file. I would have done it after installing it, or maybe I miss
    something.

    All in one, I've made the following changes, and it seems to work:

    retrieving revision 1.13
    diff -r1.13 Makefile.am
    30a31
    > $(mkinstalldirs) $(DESTDIR)$(prefix)/share/pixmaps; \ 46a48
    > $(mkinstalldirs) $(DESTDIR)$(datadir)/application-registry; \ 50c52
    < $(DESKTOP_FILE_INSTALL) --rebuild-mime-info-cache $(srcdir)/
    freedesktop/cssed.desktop; \ ---
    > $(mkinstalldirs) $(DESTDIR)$(datadir)/applications; \ 53a56
    > $(mkinstalldirs) $(DESTDIR)$(datadir)/mime-info; \ 56,58d58
    < if test -d $(PACKAGE_PREFIX)/mime; then \ < $(UPDATE_MIME_DATABASE) $(PACKAGE_PREFIX)/mime; \ < fi

     
  • Iago Rubio
    Iago Rubio
    2006-12-27

    • status: open-accepted --> closed-fixed
     
  • Iago Rubio
    Iago Rubio
    2006-12-27

    Logged In: YES
    user_id=910507
    Originator: NO

    I'm very sorry for being so late.

    I've added the code you requested to the Makefile.am so please test cvs - if you wish and have time - as it may be fixed now.

    About #3, the rebuild-mime-info is passed to desktop-file-install which installs it and rebuilds the database. I've changed it to pass to desktop-file-install the directory where to install the file. I've added the required mkinstalldirs to create the dir if not exists before to run desktop-file-install.

    I hope it works now as intended but if not, please reopen this bug.

    Thank you so much for your feedback and help.

     
  • Logged In: YES
    user_id=552580
    Originator: YES

    Happy new year.

    I've added a flag to disable update desktop database at install time and thus allow to run it in a post install script, as the directory used to prepare the package may not be the same as the final installation.

    With that and another fix to get the cssed.mime file in the tarball, it works as expected.

    Changes are in cvs (hope you don't mind), so update your local tree.