Re: [Csql-core] List of modules to do code review - allocator module

[prabakaran <pra...@ya...>]

Find my comments inlined.
Forwarding it to mailing list.  
Praba

Praba,
I was looking at allocator code. Below are the
comments I have.

file: ChunkIterator.c
• Chunk::getIterator() - why are we returning a local
variable?
PRABA::It is returning by value not by reference.

ChunkIterator::nextElement -
• checking for variable size iterator can be done in
getIterator
PRABA::Create a bug for this and assign low priority.

• Why can't we store number of elements used in
PageInfo instead of iterating? offset can be
maintained along with this to store where to allocate
next from. Tuple deletion will change this offset to
where ever needs to be allocated
• This can be written as recursive function

PRABA::Refer 1821209 for this. The Offset will be
stored in ChunkIterator object itself rather than
pageInfo object. 
Where to allocate next from is stored in Chunk object.
This offset needs to be changed to ptr.


file: Chunk.c

Chunk::getSize
•  Usage of sizeof(int) for every allocation in chunk
should be
 more
> clear. Better to have new struct and maintain this
I did not get this. Are you talking about setSize?

• Chunk::getTotalDataNodes - dont we maintain list of
rows in table  struct?
PRABA::I think u meant count of rows. It is not
maintained. Create bug for this.

Overall I feel, this allocation algorithms can be
improved to give better performance. We can take this
up later.
PRABA::create an action item for this.we will discuss
about it there.
- Ganga


      ____________________________________________________________________________________
Be a better pen pal. 
Text or chat with friends inside Yahoo! Mail. See how.  http://overview.mail.yahoo.com/