[Csp-commits] r718 - reviews

[<mk...@so...>]

Author: mkrose
Date: 2004-05-23 12:58:16 -0700 (Sun, 23 May 2004)
New Revision: 718

Added:
   reviews/change
Removed:
   reviews/change
Log:
Code review of changeset foo (created Wed May 19 01:05:32 2004)

Debian is a free operating system (OS) for your computer. An operating
system is the set of basic programs and utilities that make your computer
run. Debian uses the Linux kernel (the core of an operating system), but
most of the basic OS tools come from the GNU project; hence the name
GNU/Linux.

(MOD) //trunk/CSP/CSPSim/Source/Makefile.in
(MOD) //trunk/CSP/CSPSim/Makefile.in

Deleted: reviews/change
===================================================================
--- reviews/change	2004-05-23 19:48:36 UTC (rev 717)
+++ reviews/change	2004-05-23 19:58:16 UTC (rev 718)
@@ -1,201 +0,0 @@
-(dp0
-S'date'
-p1
-S'Wed May 19 01:05:32 2004'
-p2
-sS'delta'
-p3
-(lp4
-(S'trunk/CSP/CSPSim/Source/Makefile.in'
-p5
-S'MOD'
-p6
-(lp7
-S'Index: /b/mrose/tmp/cspsf/trunk/CSP/CSPSim/Source/Makefile.in\n'
-p8
-aS'===================================================================\n'
-p9
-aS'--- /b/mrose/tmp/cspsf/trunk/CSP/CSPSim/Source/Makefile.in\t(revision 708)\n'
-p10
-aS'+++ /b/mrose/tmp/cspsf/trunk/CSP/CSPSim/Source/Makefile.in\t(working copy)\n'
-p11
-aS'@@ -2,11 +2,11 @@\n'
-p12
-aS' \n'
-p13
-aS' BIN = $(TOPDIR)/Bin\n'
-p14
-aS' \n'
-p15
-aS'-SUBDIRS = Theater \n'
-p16
-aS'+SUBDIRS = Theater\n'
-p17
-aS' \n'
-p18
-aS' DEMETER_PREFIX = $(TOPDIR)/$(ROOT)/Demeter\n'
-p19
-aS' DEMETER_INCLUDE = -I$(DEMETER_PREFIX)\n'
-p20
-aS'-DEMETER_LIBRARY = -L$(DEMETER_PREFIX) -ldemeter_csp \n'
-p21
-aS'+DEMETER_LIBRARY = -L$(DEMETER_PREFIX) -ldemeter_csp\n'
-p22
-aS' \n'
-p23
-aS' CHUNKLOD_PREFIX = $(TOPDIR)/$(ROOT)/CSPChunkLod\n'
-p24
-aS' CHUNKLOD_LIBRARY = -L$(CHUNKLOD_PREFIX)/lib -losgChunkLod_csp\n'
-p25
-aS'@@ -14,13 +14,13 @@\n'
-p26
-aS' \n'
-p27
-aS' LIBS = $(DEMETER_LIBRARY) $(CHUNKLOD_LIBRARY)\n'
-p28
-aS' \n'
-p29
-aS'-INCLUDE = -I$(TOPDIR)/Include $(DEMETER_INCLUDE) $(CHUNKLOD_INCLUDE) -I@PYTHON_INCLUDE@ \n'
-p30
-aS'+INCLUDE = -I$(TOPDIR)/Include $(DEMETER_INCLUDE) $(CHUNKLOD_INCLUDE) -I@PYTHON_INCLUDE@\n'
-p31
-aS' \n'
-p32
-aS' BASEFL = $(GDEBUGF) $(GCFLAGS) $(INCLUDE) @SDL_FLAGS@ @SIGC_FLAGS@ #@CCGNU2_FLAGS@\n'
-p33
-aS' CFLAGS = $(filter-out -I/usr/local/include, $(BASEFL))\n'
-p34
-aS' SWCXXF = $(GCFLAGS) $(INCLUDE) @SIGC_FLAGS@\n'
-p35
-aS' LDOPTS = -Wl,-z,lazyload $(GLDOPTS) @LIBS@\n'
-p36
-aS'-SWOPTS = $(GSWOPTS) $(INCLUDE) \n'
-p37
-aS'+SWOPTS = $(GSWOPTS) $(INCLUDE)\n'
-p38
-aS' \n'
-p39
-aS' SOURCES = \\\n'
-p40
-aS' \tSystems/AircraftFlightSensors.cpp \\\n'
-p41
-aS'@@ -91,13 +91,13 @@\n'
-p42
-aS' \tVirtualBattlefield.cpp \\\n'
-p43
-aS' \tVirtualScene.cpp\n'
-p44
-aS' \n'
-p45
-aS'-OBJECTS = $(SOURCES:%.cpp=%.o) \n'
-p46
-aS'+OBJECTS = $(SOURCES:%.cpp=%.o)\n'
-p47
-aS' \n'
-p48
-aS' DEPDIR = .deps\n'
-p49
-aS' MKDEP = $(CXX) -M $(CFLAGS)\n'
-p50
-aS' SWDEP = $(SWIG) -M $(SWOPTS)\n'
-p51
-aS' DEPFILES = $(addprefix $(DEPDIR)/,$(addsuffix .d, $(SOURCES))) $(DEPDIR)/cCSP.i.swigdep\n'
-p52
-aS'-DEPFILTER = \n'
-p53
-aS'+DEPFILTER =\n'
-p54
-aS' DEPS_MAGIC := $(shell mkdir $(DEPDIR) $(DEPDIR)/Theater $(DEPDIR)/Systems > /dev/null 2>&1 || :)\n'
-p55
-aS' \n'
-p56
-aS' .PHONY: clean-deps clean all default\n'
-p57
-aS'@@ -149,16 +149,16 @@\n'
-p58
-aS' #\t$(CXX) -lswigpy -lpython2.2 -o$@ $^ $(LIBS)\n'
-p59
-aS' \n'
-p60
-aS' cCSP_wrap.cpp: cCSP.i\n'
-p61
-aS'-\t$(SWIG) $(SWOPTS) -o $@ $< \n'
-p62
-aS'+\t$(SWIG) $(SWOPTS) -o $@ $<\n'
-p63
-aS' \tmv cCSP.py $(BIN)\n'
-p64
-aS' \n'
-p65
-aS' cCSP_wrap.o: cCSP_wrap.cpp\n'
-p66
-aS' \t$(CXX) -c $(SWCXXF) $(@:.o=.cpp)\n'
-p67
-aS' \n'
-p68
-aS'-%.o: %.cpp \n'
-p69
-aS'+%.o: %.cpp\n'
-p70
-aS' \t$(CXX) -c $(CFLAGS) -o $@ $(@:.o=.cpp)\n'
-p71
-aS' \n'
-p72
-aS'-AeroDynamics.o: AeroDynamics.cpp \n'
-p73
-aS'+AeroDynamics.o: AeroDynamics.cpp\n'
-p74
-aS' \t$(CXX) -c $(CFLAGS) -O3 $(@:.o=.cpp)\n'
-p75
-aS' \t\n'
-p76
-aS' Makefile: Makefile.in\n'
-p77
-atp78
-a(S'trunk/CSP/CSPSim/Makefile.in'
-p79
-g6
-(lp80
-S'Index: /b/mrose/tmp/cspsf/trunk/CSP/CSPSim/Makefile.in\n'
-p81
-aS'===================================================================\n'
-p82
-aS'--- /b/mrose/tmp/cspsf/trunk/CSP/CSPSim/Makefile.in\t(revision 708)\n'
-p83
-aS'+++ /b/mrose/tmp/cspsf/trunk/CSP/CSPSim/Makefile.in\t(working copy)\n'
-p84
-aS'@@ -26,7 +26,6 @@\n'
-p85
-aS' \n'
-p86
-aS' InputMaps: aircraft.hid gamescreen.hid\n'
-p87
-aS' \n'
-p88
-aS'-\n'
-p89
-aS' %.hid:\n'
-p90
-aS' \t@test -e Data/Input/$@ || \\\n'
-p91
-aS' \t  ( cd Tools/HID && \\\n'
-p92
-atp93
-asS'name'
-p94
-S'foo'
-p95
-sS'description'
-p96
-(lp97
-S'Debian is a free operating system (OS) for your computer. An operating'
-p98
-aS'system is the set of basic programs and utilities that make your computer'
-p99
-aS'run. Debian uses the Linux kernel (the core of an operating system), but'
-p100
-aS'most of the basic OS tools come from the GNU project; hence the name'
-p101
-aS'GNU/Linux.'
-p102
-as.
\ No newline at end of file

Added: reviews/change
===================================================================
--- reviews/change	2004-05-23 19:48:36 UTC (rev 717)
+++ reviews/change	2004-05-23 19:58:16 UTC (rev 718)
@@ -0,0 +1,201 @@
+(dp0
+S'date'
+p1
+S'Wed May 19 01:05:32 2004'
+p2
+sS'delta'
+p3
+(lp4
+(S'trunk/CSP/CSPSim/Source/Makefile.in'
+p5
+S'MOD'
+p6
+(lp7
+S'Index: /b/mrose/tmp/cspsf/trunk/CSP/CSPSim/Source/Makefile.in\n'
+p8
+aS'===================================================================\n'
+p9
+aS'--- /b/mrose/tmp/cspsf/trunk/CSP/CSPSim/Source/Makefile.in\t(revision 708)\n'
+p10
+aS'+++ /b/mrose/tmp/cspsf/trunk/CSP/CSPSim/Source/Makefile.in\t(working copy)\n'
+p11
+aS'@@ -2,11 +2,11 @@\n'
+p12
+aS' \n'
+p13
+aS' BIN = $(TOPDIR)/Bin\n'
+p14
+aS' \n'
+p15
+aS'-SUBDIRS = Theater \n'
+p16
+aS'+SUBDIRS = Theater\n'
+p17
+aS' \n'
+p18
+aS' DEMETER_PREFIX = $(TOPDIR)/$(ROOT)/Demeter\n'
+p19
+aS' DEMETER_INCLUDE = -I$(DEMETER_PREFIX)\n'
+p20
+aS'-DEMETER_LIBRARY = -L$(DEMETER_PREFIX) -ldemeter_csp \n'
+p21
+aS'+DEMETER_LIBRARY = -L$(DEMETER_PREFIX) -ldemeter_csp\n'
+p22
+aS' \n'
+p23
+aS' CHUNKLOD_PREFIX = $(TOPDIR)/$(ROOT)/CSPChunkLod\n'
+p24
+aS' CHUNKLOD_LIBRARY = -L$(CHUNKLOD_PREFIX)/lib -losgChunkLod_csp\n'
+p25
+aS'@@ -14,13 +14,13 @@\n'
+p26
+aS' \n'
+p27
+aS' LIBS = $(DEMETER_LIBRARY) $(CHUNKLOD_LIBRARY)\n'
+p28
+aS' \n'
+p29
+aS'-INCLUDE = -I$(TOPDIR)/Include $(DEMETER_INCLUDE) $(CHUNKLOD_INCLUDE) -I@PYTHON_INCLUDE@ \n'
+p30
+aS'+INCLUDE = -I$(TOPDIR)/Include $(DEMETER_INCLUDE) $(CHUNKLOD_INCLUDE) -I@PYTHON_INCLUDE@\n'
+p31
+aS' \n'
+p32
+aS' BASEFL = $(GDEBUGF) $(GCFLAGS) $(INCLUDE) @SDL_FLAGS@ @SIGC_FLAGS@ #@CCGNU2_FLAGS@\n'
+p33
+aS' CFLAGS = $(filter-out -I/usr/local/include, $(BASEFL))\n'
+p34
+aS' SWCXXF = $(GCFLAGS) $(INCLUDE) @SIGC_FLAGS@\n'
+p35
+aS' LDOPTS = -Wl,-z,lazyload $(GLDOPTS) @LIBS@\n'
+p36
+aS'-SWOPTS = $(GSWOPTS) $(INCLUDE) \n'
+p37
+aS'+SWOPTS = $(GSWOPTS) $(INCLUDE)\n'
+p38
+aS' \n'
+p39
+aS' SOURCES = \\\n'
+p40
+aS' \tSystems/AircraftFlightSensors.cpp \\\n'
+p41
+aS'@@ -91,13 +91,13 @@\n'
+p42
+aS' \tVirtualBattlefield.cpp \\\n'
+p43
+aS' \tVirtualScene.cpp\n'
+p44
+aS' \n'
+p45
+aS'-OBJECTS = $(SOURCES:%.cpp=%.o) \n'
+p46
+aS'+OBJECTS = $(SOURCES:%.cpp=%.o)\n'
+p47
+aS' \n'
+p48
+aS' DEPDIR = .deps\n'
+p49
+aS' MKDEP = $(CXX) -M $(CFLAGS)\n'
+p50
+aS' SWDEP = $(SWIG) -M $(SWOPTS)\n'
+p51
+aS' DEPFILES = $(addprefix $(DEPDIR)/,$(addsuffix .d, $(SOURCES))) $(DEPDIR)/cCSP.i.swigdep\n'
+p52
+aS'-DEPFILTER = \n'
+p53
+aS'+DEPFILTER =\n'
+p54
+aS' DEPS_MAGIC := $(shell mkdir $(DEPDIR) $(DEPDIR)/Theater $(DEPDIR)/Systems > /dev/null 2>&1 || :)\n'
+p55
+aS' \n'
+p56
+aS' .PHONY: clean-deps clean all default\n'
+p57
+aS'@@ -149,16 +149,16 @@\n'
+p58
+aS' #\t$(CXX) -lswigpy -lpython2.2 -o$@ $^ $(LIBS)\n'
+p59
+aS' \n'
+p60
+aS' cCSP_wrap.cpp: cCSP.i\n'
+p61
+aS'-\t$(SWIG) $(SWOPTS) -o $@ $< \n'
+p62
+aS'+\t$(SWIG) $(SWOPTS) -o $@ $<\n'
+p63
+aS' \tmv cCSP.py $(BIN)\n'
+p64
+aS' \n'
+p65
+aS' cCSP_wrap.o: cCSP_wrap.cpp\n'
+p66
+aS' \t$(CXX) -c $(SWCXXF) $(@:.o=.cpp)\n'
+p67
+aS' \n'
+p68
+aS'-%.o: %.cpp \n'
+p69
+aS'+%.o: %.cpp\n'
+p70
+aS' \t$(CXX) -c $(CFLAGS) -o $@ $(@:.o=.cpp)\n'
+p71
+aS' \n'
+p72
+aS'-AeroDynamics.o: AeroDynamics.cpp \n'
+p73
+aS'+AeroDynamics.o: AeroDynamics.cpp\n'
+p74
+aS' \t$(CXX) -c $(CFLAGS) -O3 $(@:.o=.cpp)\n'
+p75
+aS' \t\n'
+p76
+aS' Makefile: Makefile.in\n'
+p77
+atp78
+a(S'trunk/CSP/CSPSim/Makefile.in'
+p79
+g6
+(lp80
+S'Index: /b/mrose/tmp/cspsf/trunk/CSP/CSPSim/Makefile.in\n'
+p81
+aS'===================================================================\n'
+p82
+aS'--- /b/mrose/tmp/cspsf/trunk/CSP/CSPSim/Makefile.in\t(revision 708)\n'
+p83
+aS'+++ /b/mrose/tmp/cspsf/trunk/CSP/CSPSim/Makefile.in\t(working copy)\n'
+p84
+aS'@@ -26,7 +26,6 @@\n'
+p85
+aS' \n'
+p86
+aS' InputMaps: aircraft.hid gamescreen.hid\n'
+p87
+aS' \n'
+p88
+aS'-\n'
+p89
+aS' %.hid:\n'
+p90
+aS' \t@test -e Data/Input/$@ || \\\n'
+p91
+aS' \t  ( cd Tools/HID && \\\n'
+p92
+atp93
+asS'name'
+p94
+S'foo'
+p95
+sS'description'
+p96
+(lp97
+S'Debian is a free operating system (OS) for your computer. An operating'
+p98
+aS'system is the set of basic programs and utilities that make your computer'
+p99
+aS'run. Debian uses the Linux kernel (the core of an operating system), but'
+p100
+aS'most of the basic OS tools come from the GNU project; hence the name'
+p101
+aS'GNU/Linux.'
+p102
+as.
\ No newline at end of file