"Foul" somehow appears to have become a player. He is listed
in the sendings off tab. I think this is caused by the
structure of the sentence in the commentary :
78:17 Sent off
Foul by Garry Flitcroft (Blackburn) on Fredrik Ljungberg
(Arsenal). Garry Flitcroft (Blackburn) dismissed for second
bookable offence...
This is probably a problem with the regular expression used
to find this event. Looking at the footballEvents.xml file,
I think the expression chooses the first word(s) immediately
after the phrase "Sent off". A way around this would be to
use the sentence structure used in "Garry Flitcroft
(Blackburn) dismissed for second bookable offence" to
extract the sent off information. This could then also be
used to decide if the sending off was a straight red card
offence (-3 points) or a second yellow card (-1 point) as
this is the normal structure used in the comentaries. The
phrases "sent off " and "dismissed" do appear to be
interchangeable though.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
You are correct (and obviously getting the hang of thie way the system
works). I am in the process of fixing the booking stuff as part of another
bug but will leave this one for you to solve, ask questions when you need to.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
At present the system does not record redCards as a separate event,
but it does need to.
I have added a redCard Event to to scoringConfig.xsl and a (non
working) event generator in the footballEvents.xml file. Not only does
this not work, but I have made a spelling error in the type attribute (it
says redCare).
The pattern I have placed in this new event won;t match anything, this
is deliberate so it doesn't stop the system working. All that is left for you
to do is make the pattern match correctly. The nearest one to what you
need to do is the booking one.
Good luck!
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
The sending off in the snippet below is not being detectd. The
commentary is available in CVS at src/test/resources/testHTML
87:53 Goal - Paolo Di Canio
Fulham 0-1 West Ham.
Foul by Zat Knight (Fulham) on Jermain Defoe (West Ham). Placed
penalty taken right-footed by Paolo Di Canio (West Ham)
(bottom-right of goal), scored.Fulham 0-1 West Ham. Zat Knight
(Fulham) dismissed for serious foul play.
I have recently tidied the detection of bookings and I think the
method used there will solve this problem if applied to sending offs
(allthough not tested)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
This is not fixed, we are still not detecting red cards. The bit about "foul"
being sent off is fixed but there is more to this bug than just that.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Game commentary
Logged In: YES
user_id=631335
"Foul" somehow appears to have become a player. He is listed
in the sendings off tab. I think this is caused by the
structure of the sentence in the commentary :
78:17 Sent off
Foul by Garry Flitcroft (Blackburn) on Fredrik Ljungberg
(Arsenal). Garry Flitcroft (Blackburn) dismissed for second
bookable offence...
This is probably a problem with the regular expression used
to find this event. Looking at the footballEvents.xml file,
I think the expression chooses the first word(s) immediately
after the phrase "Sent off". A way around this would be to
use the sentence structure used in "Garry Flitcroft
(Blackburn) dismissed for second bookable offence" to
extract the sent off information. This could then also be
used to decide if the sending off was a straight red card
offence (-3 points) or a second yellow card (-1 point) as
this is the normal structure used in the comentaries. The
phrases "sent off " and "dismissed" do appear to be
interchangeable though.
Logged In: YES
user_id=88713
You are correct (and obviously getting the hang of thie way the system
works). I am in the process of fixing the booking stuff as part of another
bug but will leave this one for you to solve, ask questions when you need to.
Logged In: YES
user_id=88713
At present the system does not record redCards as a separate event,
but it does need to.
I have added a redCard Event to to scoringConfig.xsl and a (non
working) event generator in the footballEvents.xml file. Not only does
this not work, but I have made a spelling error in the type attribute (it
says redCare).
The pattern I have placed in this new event won;t match anything, this
is deliberate so it doesn't stop the system working. All that is left for you
to do is make the pattern match correctly. The nearest one to what you
need to do is the booking one.
Good luck!
Logged In: YES
user_id=88713
The sending off in the snippet below is not being detectd. The
commentary is available in CVS at src/test/resources/testHTML
87:53 Goal - Paolo Di Canio
Fulham 0-1 West Ham.
Foul by Zat Knight (Fulham) on Jermain Defoe (West Ham). Placed
penalty taken right-footed by Paolo Di Canio (West Ham)
(bottom-right of goal), scored.Fulham 0-1 West Ham. Zat Knight
(Fulham) dismissed for serious foul play.
I have recently tidied the detection of bookings and I think the
method used there will solve this problem if applied to sending offs
(allthough not tested)
Logged In: YES
user_id=631335
It appears that this bug has somehow been fixed, probably
during the fix of another bug.
Logged In: YES
user_id=88713
This is not fixed, we are still not detecting red cards. The bit about "foul"
being sent off is fixed but there is more to this bug than just that.
Logged In: YES
user_id=88713
re-opened (see previous comments)