Re: [csjava-developer] TheButtonMatrix comments

[Toby D. <tj...@sf...>]

For now, the menus should just be an option for displaying the
load/save/close buttons. Since no one seems to need to the ability to add
extra buttons, don=B9t worry about it for now. If it=B9s easy to arrange the
code in a way so that in the future adding extra buttons is easy, then
that=B9s a bonus; but don=B9t do it if makes the implementation too complex or
hard to understand. Simplicity is more important than flexibility or
completeness, for now.

Toby


On 5/26/05 9:15 AM, "Daryl Van Humbeck" <dva...@sf...> wrote:

> Ok, I found out what I was doing wrong.
>=20
> I was calling _refit() which resizes the window to the image's size then
> centers the window, when I should have been calling center() which just
> centers the window.
> I fixed that and that solved the overlap problem.
>=20
> Though I'm still a little uncertain about how to implement the menu.
> Should I let the user add things to it?
> Should I let the user have the option of implementing the things with but=
tons
> or menu items?
> Maybe just have the default (load, save & close) as menu items and the
> user-added stuff as buttons?
> I'm not sure.
>=20
> I've added a debug line drawing option to the ImagePainter component so y=
ou
> can check to make sure the whole image is being displayed.
> Just call .enableDebugLines(true) on TheButtonMatrix object to enable the=
m.
>=20
> Daryl.
>=20
> Toby Donaldson wrote:
>> =20
>> Hi Daryl,
>>=20
>> Actually, I've check it in Windows XP, Linux, and Mac OS X (i.e. Unix), =
and
>> they each show framing problems. I don't always check them on all three,=
 but
>> in this case I did.
>>=20
>> Even the most recent versions show the same sort of problem. When I run =
the
>> test1(), test2(), test3() methods of the ButtonTest class, there is stil=
l
>> overlap at the bottom of the image.
>>=20
>> Toby
>>=20
>>=20
>> On 5/20/05 10:23 AM, "Daryl Van Humbeck" <dva...@sf...>
>> <mailto:dva...@sf...>  wrote:
>>=20
>>  =20
>> =20
>>> =20
>>> Unfortunately, I didn't see what you saw.
>>>=20
>>> Another problem I have is I only have one platform to test things on
>>> (Windows 98SE), whereas you're probably using Windows XP.
>>>=20
>>> So, I've looked at my code and tried to figure out what might cause the
>>> problems you mention, and discovered that I'm not packing the window an=
d
>>> then refitting it.
>>> I added that code and think it solves some problems.
>>>=20
>>> I haven't done anything about the ragged buttons yet, but I'll get to
>>> that soon. Maybe I can use a different Layout manager...
>>>=20
>>> Please update and test again and see if that solves those problems.
>>>=20
>>> I do agree that the buttons take up space and a menu would probably do
>>> better.
>>> Maybe some sort of system that lets the user choose from a variety of
>>> different methods of displaying a bunch of actions?
>>> i.e., some buttons, some menu items, some property (right-click) menu
>>> items, etc.
>>>=20
>>> Just some thoughts.
>>>=20
>>> Daryl.
>>>=20
>>> Toby Donaldson wrote:
>>>=20
>>>    =20
>>> =20
>>>> =20
>>>> Daryl,
>>>>=20
>>>> I've been looking at TheButtonMatrix, and I think it's nearly read to
>>>> add to TheMatrix. An essential fix is needed, though:
>>>>=20
>>>> - The image is not correctly set in the frame. The bottom of the frame
>>>> is too low, and so a gray line is visible. Also, the right side of the
>>>> entire image is apparently covered by the button panel. The image must
>>>> appear precisely in the frame, with no excess space or overlapping.
>>>>=20
>>>> In addition, there are some possible improvements that would probably
>>>> make it better, although we can live without them:
>>>>=20
>>>> - The button panel background is big, gray, and unappealing. Can it be
>>>> white instead? Can a method to set the button panel background be adde=
d?
>>>> - When the button panel is put on the left side of the image, the
>>>> right edge of the buttons is ragged because the buttons are not the
>>>> same width. This looks messy and should be fixed, i.e. the buttons
>>>> should be made the same width.
>>>> - After seeing the button panels, I think a menu bar with a menu
>>>> containing the save/load/close features would probably look nicer. For
>>>> beginners, having the buttons right on the screen where they can see
>>>> them is good, because then they don't need to hunt around or guess
>>>> what features are available. But there is so much unused space, that
>>>> after a while I suspect many users will find that to be a bit of an
>>>> eyesore. So a menu bar might be the nicest way to deal with this.
>>>> - And speaking of the menu bar, another possibility is to use a
>>>> mouse-click menu, e.g. when the user, say, right-clicks on the image,
>>>> a menu with the save/load/close options would pop up. For frequent
>>>> users of TheMatrix, this might be popular.
>>>>=20
>>>> I added the file ButtonTest into your developer package on CVS with a
>>>> few more test rungs, including a few comments. I also add the method
>>>> "enableAllButtons" to TheButtonMatrix.
>>>>=20
>>>> Toby
>>>>=20
>>>>=20
>>>> -------------------------------------------------------
>>>> This SF.Net email is sponsored by Oracle Space Sweepstakes
>>>> Want to be the first software developer in space?
>>>> Enter now for the Oracle Space Sweepstakes!
>>>> http://ads.osdn.com/?ad_id=3D7412&alloc_id=3D16344&op=3Dclick
>>>> _______________________________________________
>>>> csjava-developer mailing list
>>>> csj...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/csjava-developer
>>>>=20
>>>>=20
>>>>=20
>>>>      =20
>>>> =20
>>> =20
>>>=20
>>>    =20
>>> =20
>> =20
>>=20
>>  =20
>=20
>=20
>=20
> No virus found in this outgoing message.
> Checked by AVG Anti-Virus.
> Version: 7.0.322 / Virus Database: 266.11.17 - Release Date: 25/05/05


--=20
Dr. Toby Donaldson
School of Computing Science
Simon Fraser University