Menu

#2784 Better logging on sipwakelock

New
nobody
None
Medium
Defect
2014-10-11
2014-10-03
Anonymous
No

Originally created by: phtr...@gmail.com

Sometimes sipwakelock kept my phone awake for 70% of the time, and I don't know how to find out the problem.

I have some suggestions regarding this:

a. SipWakeLock.acquire() should add more log info about the reason of locking.
b. In "TimerWrapper.java", the TimerJob should not grab the wakelock in initialization, but when running it.

Thanks

Discussion

  • Anonymous

    Anonymous - 2014-10-03

    Originally posted by: phtr...@gmail.com

    Another suggestion: Add exception handling for failure in acquiring wakelock from system.

    Many ROMs and MODs allow users to disable wakelock for a specific app, such as CM11 privacy guard, or xposed modules. Currently csipsimple will crash immediately. As an end user, I would rather take the risk of some misfunction due to lack of wakelocks, rather than crash on start.

     
  • Anonymous

    Anonymous - 2014-10-11

    Originally posted by: phtr...@gmail.com

    I noticed the constant wakelock usually happens after network switched from wifi to cell or vice versa.

     

Log in to post a comment.